Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 224333002: cc: Skip analysis for narrow layers. (Closed)

Created:
6 years, 8 months ago by vmpstr
Modified:
6 years, 8 months ago
Reviewers:
reveman, alokp
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Skip analysis for narrow layers. This patch ensures that we skip analysis for narrow layers. These layers are unlikely to have solid color, and we shouldn't spend time analyzing them. Additionally, we need to be cautious and set has_text to be true by default, since for tiles that skipped analysis, we have to assume that they have text. (original CL: https://codereview.chromium.org/213093003/) R=reveman, alokp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261794

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M cc/resources/picture_pile_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/resources/tile_manager.cc View 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
vmpstr
Hey, can you take a look at this? I've been trying to land this via ...
6 years, 8 months ago (2014-04-03 17:51:11 UTC) #1
alokp
lgtm
6 years, 8 months ago (2014-04-03 17:56:44 UTC) #2
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 8 months ago (2014-04-03 22:19:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/224333002/1
6 years, 8 months ago (2014-04-03 22:19:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 23:38:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 23:38:57 UTC) #6
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 8 months ago (2014-04-04 00:01:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/224333002/1
6 years, 8 months ago (2014-04-04 00:02:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 00:08:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-04 00:08:09 UTC) #10
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 8 months ago (2014-04-04 17:09:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/224333002/1
6 years, 8 months ago (2014-04-04 17:10:22 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 18:25:22 UTC) #13
Message was sent while issue was closed.
Change committed as 261794

Powered by Google App Engine
This is Rietveld 408576698