Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 22432009: Don't use Persistent in runtime (Closed)

Created:
7 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M src/i18n.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/i18n.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-12 08:33:17 UTC) #1
dcarney
lgtm
7 years, 4 months ago (2013-08-12 08:34:45 UTC) #2
Michael Starzinger
LGTM, I like this, no more v8::Foo namespace in the runtime.
7 years, 4 months ago (2013-08-12 08:35:45 UTC) #3
jochen (gone - plz use gerrit)
7 years, 4 months ago (2013-08-20 08:08:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16234.

Powered by Google App Engine
This is Rietveld 408576698