src/i18n.cc - Issue 22432009: Don't use Persistent in runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/i18n.cc

Issue 22432009: Don't use Persistent in runtime (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: updates Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/i18n.cc

diff --git a/src/i18n.cc b/src/i18n.cc

index e58e86823a93458a8500fec85446f6c6886c4688..11941331c9ef42721258dfb2e0fd8a33e7d076d2 100644

--- a/src/i18n.cc

+++ b/src/i18n.cc

@@ -797,7 +797,7 @@ icu::SimpleDateFormat* DateFormat::UnpackDateFormat(

void DateFormat::DeleteDateFormat(v8::Isolate* isolate,

- Persistent<v8::Object>* object,

+ Persistent<v8::Value>* object,

void* param) {

// First delete the hidden C++ object.

delete reinterpret_cast<icu::SimpleDateFormat*>(Handle<JSObject>::cast(

@@ -860,7 +860,7 @@ icu::DecimalFormat* NumberFormat::UnpackNumberFormat(

void NumberFormat::DeleteNumberFormat(v8::Isolate* isolate,

- Persistent<v8::Object>* object,

+ Persistent<v8::Value>* object,

void* param) {

// First delete the hidden C++ object.

delete reinterpret_cast<icu::DecimalFormat*>(Handle<JSObject>::cast(

@@ -920,7 +920,7 @@ icu::Collator* Collator::UnpackCollator(Isolate* isolate,

void Collator::DeleteCollator(v8::Isolate* isolate,

- Persistent<v8::Object>* object,

+ Persistent<v8::Value>* object,

void* param) {

// First delete the hidden C++ object.

delete reinterpret_cast<icu::Collator*>(Handle<JSObject>::cast(

« no previous file with comments | « src/i18n.h ('k') | src/runtime.cc » ('j') | no next file with comments »