Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1736)

Unified Diff: content/public/browser/bluetooth_chooser.h

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address more comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/bluetooth_chooser.h
diff --git a/content/public/browser/bluetooth_chooser.h b/content/public/browser/bluetooth_chooser.h
index ea2b4f554f95288f8e66a579e469629c9b7810b9..84b5cbea65a806a3de3147a8138eaa052981ec2a 100644
--- a/content/public/browser/bluetooth_chooser.h
+++ b/content/public/browser/bluetooth_chooser.h
@@ -69,8 +69,13 @@ class CONTENT_EXPORT BluetoothChooser {
virtual void ShowDiscoveryState(DiscoveryState state) {}
// Adds a new device to the chooser or updates the information of an existing
- // device. Passing nullptr for |rssi| means that the device doesn't not have
- // RSSI which happens when the device is already connected.
+ // device.
+ //
+ // Sometimes when a Bluetooth device stops advertising, the |device_name| can
+ // be invalid, and in that case |should_update_name| will be set false.
+ //
+ // Passing nullptr for |rssi| means that the device doesn't have RSSI which
+ // happens when the device is already connected.
virtual void AddOrUpdateDevice(const std::string& device_id,
bool should_update_name,
const base::string16& device_name,
« no previous file with comments | « content/browser/bluetooth/bluetooth_device_chooser_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698