content/browser/bluetooth/bluetooth_device_chooser_controller.cc - Issue 2242943002: Update device name in chooser when device changes name (desktops)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_device_chooser_controller.cc

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address more comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc ('k') | content/public/browser/bluetooth_chooser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bluetooth/bluetooth_device_chooser_controller.cc

diff --git a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc

index b2d8792f0c4a5fd5ddccd1b9594b719793ec41df..d588cde896c603955f10c076c1273ac02841b92a 100644

--- a/content/browser/bluetooth/bluetooth_device_chooser_controller.cc

+++ b/content/browser/bluetooth/bluetooth_device_chooser_controller.cc

@@ -340,9 +340,8 @@ void BluetoothDeviceChooserController::AddFilteredDevice(

const device::BluetoothDevice& device) {

if (chooser_.get() && MatchesFilters(device, options_->filters)) {

chooser_->AddOrUpdateDevice(

- device.GetAddress(),

- // TODO(https://crbug.com/634366): Update device's name when necessary.

- false /* should_update_name */, device.GetNameForDisplay(),

+ device.GetAddress(), !!device.GetName() /* should_update_name */,

+ device.GetNameForDisplay(),

// TODO(http://crbug.com/543466): Show connection and paired status.

false /* is_gatt_connected */, false /* is_paired */,

// TODO(http://crbug.com/629689): Add signal strength indicator.

« no previous file with comments | « chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc ('k') | content/public/browser/bluetooth_chooser.h » ('j') | no next file with comments »