chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm - Issue 2242943002: Update device name in chooser when device changes name (desktops)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address more comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bluetooth/bluetooth_chooser_controller.cc ('k') | chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm b/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

index bbb11114c41b2d20ec937cdf221ad76bf953a115..dd9fce5ee84234608c362d86616ec815db820393 100644

--- a/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

+++ b/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

@@ -58,6 +58,7 @@ class ChooserContentViewController : public ChooserController::View {

void OnOptionsInitialized() override;

void OnOptionAdded(size_t index) override;

void OnOptionRemoved(size_t index) override;

+ void OnOptionUpdated(size_t index) override;

void OnAdapterEnabledChanged(bool enabled) override;

void OnRefreshStateChanged(bool refreshing) override;

@@ -127,6 +128,10 @@ void ChooserContentViewController::OnOptionRemoved(size_t index) {

UpdateTableView();

}

+void ChooserContentViewController::OnOptionUpdated(size_t index) {

+ UpdateTableView();

void ChooserContentViewController::OnAdapterEnabledChanged(bool enabled) {

// No row is selected since the adapter status has changed.

// This will also disable the OK button if it was enabled because