Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address more comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h" 5 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 NSTableView* table_view, 51 NSTableView* table_view,
52 SpinnerView* spinner, 52 SpinnerView* spinner,
53 NSTextField* status, 53 NSTextField* status,
54 NSButton* rescan_button); 54 NSButton* rescan_button);
55 ~ChooserContentViewController() override; 55 ~ChooserContentViewController() override;
56 56
57 // ChooserController::View: 57 // ChooserController::View:
58 void OnOptionsInitialized() override; 58 void OnOptionsInitialized() override;
59 void OnOptionAdded(size_t index) override; 59 void OnOptionAdded(size_t index) override;
60 void OnOptionRemoved(size_t index) override; 60 void OnOptionRemoved(size_t index) override;
61 void OnOptionUpdated(size_t index) override;
61 void OnAdapterEnabledChanged(bool enabled) override; 62 void OnAdapterEnabledChanged(bool enabled) override;
62 void OnRefreshStateChanged(bool refreshing) override; 63 void OnRefreshStateChanged(bool refreshing) override;
63 64
64 void UpdateTableView(); 65 void UpdateTableView();
65 66
66 private: 67 private:
67 ChooserContentViewCocoa* chooser_content_view_; 68 ChooserContentViewCocoa* chooser_content_view_;
68 ChooserController* chooser_controller_; 69 ChooserController* chooser_controller_;
69 NSTableView* table_view_; 70 NSTableView* table_view_;
70 SpinnerView* spinner_; 71 SpinnerView* spinner_;
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 if (selected_row == idx) 121 if (selected_row == idx)
121 [table_view_ deselectRow:idx]; 122 [table_view_ deselectRow:idx];
122 else if (selected_row > idx) 123 else if (selected_row > idx)
123 [table_view_ 124 [table_view_
124 selectRowIndexes:[NSIndexSet indexSetWithIndex:selected_row - 1] 125 selectRowIndexes:[NSIndexSet indexSetWithIndex:selected_row - 1]
125 byExtendingSelection:NO]; 126 byExtendingSelection:NO];
126 127
127 UpdateTableView(); 128 UpdateTableView();
128 } 129 }
129 130
131 void ChooserContentViewController::OnOptionUpdated(size_t index) {
132 UpdateTableView();
133 }
134
130 void ChooserContentViewController::OnAdapterEnabledChanged(bool enabled) { 135 void ChooserContentViewController::OnAdapterEnabledChanged(bool enabled) {
131 // No row is selected since the adapter status has changed. 136 // No row is selected since the adapter status has changed.
132 // This will also disable the OK button if it was enabled because 137 // This will also disable the OK button if it was enabled because
133 // of a previously selected row. 138 // of a previously selected row.
134 [table_view_ deselectAll:nil]; 139 [table_view_ deselectAll:nil];
135 UpdateTableView(); 140 UpdateTableView();
136 [table_view_ setHidden:NO]; 141 [table_view_ setHidden:NO];
137 142
138 [spinner_ setHidden:YES]; 143 [spinner_ setHidden:YES];
139 144
(...skipping 424 matching lines...) Expand 10 before | Expand all | Expand 10 after
564 569
565 - (void)onRescan:(id)sender { 570 - (void)onRescan:(id)sender {
566 chooserController_->RefreshOptions(); 571 chooserController_->RefreshOptions();
567 } 572 }
568 573
569 - (void)onHelpPressed:(id)sender { 574 - (void)onHelpPressed:(id)sender {
570 chooserController_->OpenHelpCenterUrl(); 575 chooserController_->OpenHelpCenterUrl();
571 } 576 }
572 577
573 @end 578 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698