Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2262)

Unified Diff: components/feedback/feedback_report.h

Issue 2242833003: Add the most recent crash report IDs to feedback reports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/feedback/feedback_common.cc ('k') | components/feedback/feedback_report.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/feedback_report.h
diff --git a/components/feedback/feedback_report.h b/components/feedback/feedback_report.h
index 15cac5c76f4e5c514cbdc032d1796236364efe31..01dda201e087d0c1d8b373e2ed14c0df936c7b58 100644
--- a/components/feedback/feedback_report.h
+++ b/components/feedback/feedback_report.h
@@ -31,6 +31,15 @@ class FeedbackReport : public base::RefCounted<FeedbackReport> {
const std::string& data,
scoped_refptr<base::SequencedTaskRunner> task_runner);
+ // The ID of the product specific data for the crash report IDs as stored by
+ // the feedback server.
+ static constexpr char kCrashReportIdsKey[] = "crash_report_ids";
afakhry 2016/09/13 17:46:37 This would still cause compile errors on Windows:
Rahul Chaturvedi 2016/09/13 18:02:55 Weird. I am also not seeing any usages of this in
+
+ // Loads the reports still on disk and queues then using the given callback.
+ // This call blocks on the file reads.
+ static void LoadReportsAndQueue(const base::FilePath& user_dir,
+ QueueCallback callback);
+
// Stops the disk write of the report and deletes the report file if already
// written.
void DeleteReportOnDisk();
@@ -38,11 +47,6 @@ class FeedbackReport : public base::RefCounted<FeedbackReport> {
const base::Time& upload_at() const { return upload_at_; }
const std::string& data() const { return data_; }
- // Loads the reports still on disk and queues then using the given callback.
- // This call blocks on the file reads.
- static void LoadReportsAndQueue(const base::FilePath& user_dir,
- QueueCallback callback);
-
private:
friend class base::RefCounted<FeedbackReport>;
virtual ~FeedbackReport();
« no previous file with comments | « components/feedback/feedback_common.cc ('k') | components/feedback/feedback_report.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698