Add the most recent crash report IDs to feedback reports

components/feedback/feedback_report.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FEEDBACK_FEEDBACK_REPORT_H_
 #define COMPONENTS_FEEDBACK_FEEDBACK_REPORT_H_
 
 #include <string>
 
 #include "base/callback_forward.h"
@@ skipping 13 matching lines @@
 // This class holds a feedback report. Once a report is created, a disk backup
 // for it is created automatically. This backup needs to explicitly be
 // deleted by calling DeleteReportOnDisk.
 class FeedbackReport : public base::RefCounted<FeedbackReport> {
  public:
   FeedbackReport(const base::FilePath& path,
                  const base::Time& upload_at,
                  const std::string& data,
                  scoped_refptr<base::SequencedTaskRunner> task_runner);
 
+  // The ID of the product specific data for the crash report IDs as stored by
+  // the feedback server.
+  static constexpr char kCrashReportIdsKey[] = "crash_report_ids";

[afakhry, 2016/09/13 17:46:37]

This would still cause compile errors on Windows:

FAILED: obj/chrome/browser/browser/crash_ids_source.obj 
ninja -t msvc -e environment.x64 -- E:\b\c\cipd\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs_files\d5dc33b15d1b2c086f2f6632e2fd15882f80dbd3\VC\bin\amd64/cl.exe"
/nologo /showIncludes /FC @obj/chrome/browser/browser/crash_ids_source.obj.rsp
/c ../../chrome/browser/feedback/system_logs/log_sources/crash_ids_source.cc
/Foobj/chrome/browser/browser/crash_ids_source.obj
/Fd"obj/chrome/browser/browser_cc.pdb"
e:\b\c\b\win\src\components\feedback\feedback_report.h(36): error C2131:
expression did not evaluate to a constant
e:\b\c\b\win\src\components\feedback\feedback_report.h(36): note: failure was
caused by unevaluable pointer value

[Rahul Chaturvedi, 2016/09/13 18:02:55]

Weird. I am also not seeing any usages of this in current code, maybe it is just
broken.
const should be fine, this was a nit anyway.

+
+  // Loads the reports still on disk and queues then using the given callback.
+  // This call blocks on the file reads.
+  static void LoadReportsAndQueue(const base::FilePath& user_dir,
+                                  QueueCallback callback);
+
   // Stops the disk write of the report and deletes the report file if already
   // written.
   void DeleteReportOnDisk();
 
   const base::Time& upload_at() const { return upload_at_; }
   const std::string& data() const { return data_; }
 
-  // Loads the reports still on disk and queues then using the given callback.
-  // This call blocks on the file reads.
-  static void LoadReportsAndQueue(const base::FilePath& user_dir,
-                                  QueueCallback callback);
-
  private:
   friend class base::RefCounted<FeedbackReport>;
   virtual ~FeedbackReport();
 
   // Name of the file corresponding to this report.
   base::FilePath file_;
 
   base::FilePath reports_path_;
   base::Time upload_at_;  // Upload this report at or after this time.
   std::string data_;
 
   scoped_refptr<base::SequencedTaskRunner> reports_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(FeedbackReport);
 };
 
 }  // namespace feedback
 
 #endif  // COMPONENTS_FEEDBACK_FEEDBACK_REPORT_H_