Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2242773003: Revert of ResizeObserver pt6: integration (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
Reviewers:
esprehn, eae, atotic1
CC:
ikilpatrick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ResizeObserver pt6: integration (patchset #8 id:140001 of https://codereview.chromium.org/2204503002/ ) Reason for revert: Causing layout test failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21873 Original issue's description: > ResizeObserver pt6: integration > > Integrates ResizeObserver with the browser. > > 1) Element notifies ResizeObserver when its size might have changed. > > Operations that might change Element's observed size are trapped: > Element::detachLayoutTree traps Element removal from DOM tree > LayoutObject::setMayNeedPaintInvalidation traps size changes > > 2) Event loop integration > > FrameView::notifyResizeObserver implements it per spec. > https://wicg.github.io/ResizeObserver/#html-event-loop > > 3) Tests > > LayoutTests/resize-observer is a comprehensive test suite. > > BUG=612962 > > Committed: https://crrev.com/5b49641e336ba9be7789cc0eb2511d415f4e6d5d > Cr-Commit-Position: refs/heads/master@{#411694} TBR=esprehn@chromium.org,eae@chromium.org,atotic@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612962 Committed: https://crrev.com/3a90be8802ad03103e06bb5568343171259094e0 Cr-Commit-Position: refs/heads/master@{#411725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1324 lines) Patch
D third_party/WebKit/LayoutTests/resize-observer/eventloop.html View 1 chunk +0 lines, -266 lines 0 comments Download
D third_party/WebKit/LayoutTests/resize-observer/notify.html View 1 chunk +0 lines, -361 lines 0 comments Download
D third_party/WebKit/LayoutTests/resize-observer/observe.html View 1 chunk +0 lines, -160 lines 0 comments Download
D third_party/WebKit/LayoutTests/resize-observer/resources/iframe.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/resize-observer/resources/resizeTestHelper.js View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/resize-observer/svg.html View 1 chunk +0 lines, -297 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 4 chunks +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGEllipse.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGPath.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRect.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xidachen
Created Revert of ResizeObserver pt6: integration
4 years, 4 months ago (2016-08-12 19:05:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242773003/1
4 years, 4 months ago (2016-08-12 19:05:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 19:06:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a90be8802ad03103e06bb5568343171259094e0 Cr-Commit-Position: refs/heads/master@{#411725}
4 years, 4 months ago (2016-08-12 19:10:05 UTC) #7
eae
4 years, 4 months ago (2016-08-12 19:59:59 UTC) #8
Message was sent while issue was closed.
LGTM :(

Powered by Google App Engine
This is Rietveld 408576698