third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp - Issue 2242743002: Make custom elements work in HTML imports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve most comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

index a83869148d46a6c8358c22cf70e3f2baf51549b8..1f356b417fc342d851b5ac01885e28b4072e0293 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

@@ -224,4 +224,6 @@ TEST_F(CustomElementUpgradeSorterTest, sorter_shadow)

EXPECT_EQ(d, elements[2].get());

}

+// TODO(kochi): Add test cases which uses HTML imports.

dominicc (has gone to gerrit) 2016/08/22 08:07:36 Yes please! :)

} // namespace blink