third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorterTest.cpp

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve most comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/dom/custom/CustomElementUpgradeSorter.h"	5 #include "core/dom/custom/CustomElementUpgradeSorter.h"

6	6

7 #include "bindings/core/v8/ExceptionState.h"	7 #include "bindings/core/v8/ExceptionState.h"

8 #include "core/HTMLNames.h"	8 #include "core/HTMLNames.h"

9 #include "core/dom/Document.h"	9 #include "core/dom/Document.h"

10 #include "core/dom/Element.h"	10 #include "core/dom/Element.h"

(...skipping 206 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
217 sort.add(d);	217 sort.add(d);

218	218

219 HeapVector<Member<Element>> elements;	219 HeapVector<Member<Element>> elements;

220 sort.sorted(&elements, document());	220 sort.sorted(&elements, document());

221 EXPECT_EQ(3u, elements.size());	221 EXPECT_EQ(3u, elements.size());

222 EXPECT_EQ(a, elements[0].get());	222 EXPECT_EQ(a, elements[0].get());

223 EXPECT_EQ(c, elements[1].get());	223 EXPECT_EQ(c, elements[1].get());

224 EXPECT_EQ(d, elements[2].get());	224 EXPECT_EQ(d, elements[2].get());

225 }	225 }

226	226

	227 // TODO(kochi): Add test cases which uses HTML imports.
	dominicc (has gone to gerrit) 2016/08/22 08:07:36 Yes please! :) Yes please! :)
	228

227 } // namespace blink	229 } // namespace blink

OLD	NEW