content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix redundant set needs begin frames Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_guest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/renderer_host/render_widget_host_view_mus.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index e3b446e0ac6eb767a26470c2316a58d024e4a335..481d427810fa6012122e0d0a7b52dfe60f18a041 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -561,8 +561,6 @@ bool RenderWidgetHostViewMac::OnMessageReceived(const IPC::Message& message) {

IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewMac, message)

IPC_MESSAGE_HANDLER(ViewMsg_GetRenderedTextCompleted,

OnGetRenderedTextCompleted)

- IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,

- OnSetNeedsBeginFrames)

IPC_MESSAGE_UNHANDLED(handled = false)

IPC_END_MESSAGE_MAP()

return handled;

@@ -1127,7 +1125,7 @@ void RenderWidgetHostViewMac::ForwardMouseEvent(const WebMouseEvent& event) {

}

-void RenderWidgetHostViewMac::OnSetNeedsBeginFrames(bool needs_begin_frames) {

+void RenderWidgetHostViewMac::SetNeedsBeginFrames(bool needs_begin_frames) {

browser_compositor_->SetNeedsBeginFrames(needs_begin_frames);

}