content/browser/renderer_host/render_widget_host_view_mac.h - Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.h

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix redundant set needs begin frames Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_guest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.h

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.h b/content/browser/renderer_host/render_widget_host_view_mac.h

index e9c8b683b34c229f67e09aa9a44435c306d0999a..a1f420f89c85ba039a4c243b36d3b53b8ebeb8b7 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.h

+++ b/content/browser/renderer_host/render_widget_host_view_mac.h

@@ -276,6 +276,7 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

bool IsSpeaking() const override;

void StopSpeaking() override;

void SetBackgroundColor(SkColor color) override;

+ void SetNeedsBeginFrames(bool needs_begin_frames) override;

// Implementation of RenderWidgetHostViewBase.

void InitAsPopup(RenderWidgetHostView* parent_host_view,

@@ -369,9 +370,6 @@ class CONTENT_EXPORT RenderWidgetHostViewMac

// Forwards the mouse event to the renderer.

void ForwardMouseEvent(const blink::WebMouseEvent& event);

- // Called when RenderWidget wants to start BeginFrame scheduling or stop.

- void OnSetNeedsBeginFrames(bool needs_begin_frames);

void KillSelf();

void SetTextInputActive(bool active);