fxjs/fxjs_v8_embeddertest.cpp - Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fxjs/fxjs_v8_embeddertest.cpp

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fxjs/fxjs_v8_embeddertest.cpp

diff --git a/fxjs/fxjs_v8_embeddertest.cpp b/fxjs/fxjs_v8_embeddertest.cpp

index b33ddca32d95e91c321c728b5d8b6d3aeca0f0b0..71b004c14428ca27e6037d9548ba294ed053009f 100644

--- a/fxjs/fxjs_v8_embeddertest.cpp

+++ b/fxjs/fxjs_v8_embeddertest.cpp

@@ -26,7 +26,8 @@ class FXJSV8EmbedderTest : public JSEmbedderTest {

}

void CheckAssignmentInCurrentContext(double expected) {

v8::Local<v8::Object> This = FXJS_GetThisObj(isolate());

- v8::Local<v8::Value> fred = FXJS_GetObjectElement(isolate(), This, L"fred");

+ v8::Local<v8::Value> fred =

+ FXJS_GetObjectProperty(isolate(), This, L"fred");

EXPECT_TRUE(fred->IsNumber());

EXPECT_EQ(expected, fred->ToNumber(isolate()->GetCurrentContext())

.ToLocalChecked()

« no previous file with comments | « fxjs/fxjs_v8.cpp ('k') | fxjs/include/fxjs_v8.h » ('j') | no next file with comments »