Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: fpdfsdk/javascript/Document.cpp

Issue 2242593002: Make FXJS_GetObjectElement return std::vector<CFX_WideString>. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Value.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/Document.cpp
diff --git a/fpdfsdk/javascript/Document.cpp b/fpdfsdk/javascript/Document.cpp
index ea77e1cfad46fb660f450c43b88d73d477a7a6cb..a55bf81139459d130093a97135b01da0d07038e1 100644
--- a/fpdfsdk/javascript/Document.cpp
+++ b/fpdfsdk/javascript/Document.cpp
@@ -615,17 +615,17 @@ FX_BOOL Document::submitForm(IJS_Context* cc,
} else if (v.GetType() == CJS_Value::VT_object) {
v8::Local<v8::Object> pObj = params[0].ToV8Object(pIsolate);
v8::Local<v8::Value> pValue =
- FXJS_GetObjectElement(pIsolate, pObj, L"cURL");
+ FXJS_GetObjectProperty(pIsolate, pObj, L"cURL");
if (!pValue.IsEmpty())
strURL = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"bFDF");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"bFDF");
bFDF = CJS_Value(pRuntime, pValue).ToBool(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"bEmpty");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"bEmpty");
bEmpty = CJS_Value(pRuntime, pValue).ToBool(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"aFields");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"aFields");
aFields.Attach(CJS_Value(pRuntime, pValue).ToV8Array(pIsolate));
}
@@ -712,22 +712,23 @@ FX_BOOL Document::mailDoc(IJS_Context* cc,
if (params.size() >= 1 && params[0].GetType() == CJS_Value::VT_object) {
v8::Local<v8::Object> pObj = params[0].ToV8Object(pIsolate);
- v8::Local<v8::Value> pValue = FXJS_GetObjectElement(pIsolate, pObj, L"bUI");
+ v8::Local<v8::Value> pValue =
+ FXJS_GetObjectProperty(pIsolate, pObj, L"bUI");
bUI = CJS_Value(pRuntime, pValue).ToInt(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"cTo");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"cTo");
cTo = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"cCc");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"cCc");
cCc = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"cBcc");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"cBcc");
cBcc = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"cSubject");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"cSubject");
cSubject = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
- pValue = FXJS_GetObjectElement(pIsolate, pObj, L"cMsg");
+ pValue = FXJS_GetObjectProperty(pIsolate, pObj, L"cMsg");
cMsg = CJS_Value(pRuntime, pValue).ToCFXWideString(pIsolate);
}
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Value.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698