Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/ast/variables.h

Issue 2242583003: [Parser] Remove Variable::is_possibly_eval. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@toon_cl
Patch Set: Address comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/variables.h
diff --git a/src/ast/variables.h b/src/ast/variables.h
index 57448245290d5bc9474b52a581af87c97f445192..261965f2c3d8be09188d06609d830c4c7e322785 100644
--- a/src/ast/variables.h
+++ b/src/ast/variables.h
@@ -82,17 +82,6 @@ class Variable: public ZoneObject {
bool is_this() const { return kind_ == THIS; }
bool is_arguments() const { return kind_ == ARGUMENTS; }
- // True if the variable is named eval and not known to be shadowed.
- bool is_possibly_eval(Isolate* isolate,
- HandleDereferenceMode deref_mode =
- HandleDereferenceMode::kAllowed) const {
- // Note: it is safe to dereference isolate->factory()->eval_string() here
- // regardless of |deref_mode| because it is a constant root and so will
- // never be updated or moved.
- return !is_this() &&
- name_is_identical_to(isolate->factory()->eval_string(), deref_mode);
- }
-
Variable* local_if_not_shadowed() const {
DCHECK(mode_ == DYNAMIC_LOCAL && local_if_not_shadowed_ != NULL);
return local_if_not_shadowed_;
@@ -116,20 +105,6 @@ class Variable: public ZoneObject {
static int CompareIndex(Variable* const* v, Variable* const* w);
private:
- bool name_is_identical_to(Handle<Object> object,
- HandleDereferenceMode deref_mode) const {
- if (deref_mode == HandleDereferenceMode::kAllowed) {
- return *name() == *object;
- } else {
- // If handle dereference isn't allowed use the handle address for
- // identity. This depends on the variable name being internalized in a
- // CanonicalHandleScope, so that all handles created during the
- // internalization with identical values have identical locations, and any
- // handles created which point to roots have the root handle's location.
- return name().address() == object.address();
- }
- }
-
Scope* scope_;
const AstRawString* name_;
VariableMode mode_;
« no previous file with comments | « src/ast/ast.cc ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698