Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: src/ast/ast.cc

Issue 2242583003: [Parser] Remove Variable::is_possibly_eval. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@toon_cl
Patch Set: Address comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/variables.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.cc
diff --git a/src/ast/ast.cc b/src/ast/ast.cc
index c1b424488a97f3a4b81804bdd6c88168fb4da508..4367746b65fa529534ee795f73c9c74bc9e212ef 100644
--- a/src/ast/ast.cc
+++ b/src/ast/ast.cc
@@ -888,38 +888,31 @@ bool Expression::IsMonomorphic() const {
}
}
-bool Call::IsUsingCallFeedbackICSlot(
- Isolate* isolate, HandleDereferenceMode dereference_mode) const {
- CallType call_type = GetCallType(isolate, dereference_mode);
- if (call_type == POSSIBLY_EVAL_CALL) {
- return false;
- }
- return true;
+bool Call::IsUsingCallFeedbackICSlot() const {
+ return GetCallType() != POSSIBLY_EVAL_CALL;
}
-bool Call::IsUsingCallFeedbackSlot(
- Isolate* isolate, HandleDereferenceMode dereference_mode) const {
+bool Call::IsUsingCallFeedbackSlot() const {
// SuperConstructorCall uses a CallConstructStub, which wants
// a Slot, in addition to any IC slots requested elsewhere.
- return GetCallType(isolate, dereference_mode) == SUPER_CALL;
+ return GetCallType() == SUPER_CALL;
}
void Call::AssignFeedbackVectorSlots(Isolate* isolate, FeedbackVectorSpec* spec,
FeedbackVectorSlotCache* cache) {
- if (IsUsingCallFeedbackICSlot(isolate)) {
+ if (IsUsingCallFeedbackICSlot()) {
ic_slot_ = spec->AddCallICSlot();
}
- if (IsUsingCallFeedbackSlot(isolate)) {
+ if (IsUsingCallFeedbackSlot()) {
stub_slot_ = spec->AddGeneralSlot();
}
}
-Call::CallType Call::GetCallType(Isolate* isolate,
- HandleDereferenceMode deref_mode) const {
+Call::CallType Call::GetCallType() const {
VariableProxy* proxy = expression()->AsVariableProxy();
if (proxy != NULL) {
- if (proxy->var()->is_possibly_eval(isolate, deref_mode)) {
+ if (is_possibly_eval()) {
return POSSIBLY_EVAL_CALL;
} else if (proxy->var()->IsUnallocatedOrGlobalSlot()) {
return GLOBAL_CALL;
« no previous file with comments | « src/ast/ast.h ('k') | src/ast/variables.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698