Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp

Issue 2242573002: Don't delay setting of channelInterpretation and channelCountMode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix grammar in comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 ConvolverHandler::ConvolverHandler(AudioNode& node, float sampleRate) 45 ConvolverHandler::ConvolverHandler(AudioNode& node, float sampleRate)
46 : AudioHandler(NodeTypeConvolver, node, sampleRate) 46 : AudioHandler(NodeTypeConvolver, node, sampleRate)
47 , m_normalize(true) 47 , m_normalize(true)
48 { 48 {
49 addInput(); 49 addInput();
50 addOutput(2); 50 addOutput(2);
51 51
52 // Node-specific default mixing rules. 52 // Node-specific default mixing rules.
53 m_channelCount = 2; 53 m_channelCount = 2;
54 m_channelCountMode = ClampedMax; 54 setInternalChannelCountMode(ClampedMax);
55 m_channelInterpretation = AudioBus::Speakers; 55 setInternalChannelInterpretation(AudioBus::Speakers);
56 56
57 initialize(); 57 initialize();
58 } 58 }
59 59
60 PassRefPtr<ConvolverHandler> ConvolverHandler::create(AudioNode& node, float sam pleRate) 60 PassRefPtr<ConvolverHandler> ConvolverHandler::create(AudioNode& node, float sam pleRate)
61 { 61 {
62 return adoptRef(new ConvolverHandler(node, sampleRate)); 62 return adoptRef(new ConvolverHandler(node, sampleRate));
63 } 63 }
64 64
65 ConvolverHandler::~ConvolverHandler() 65 ConvolverHandler::~ConvolverHandler()
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 return convolverHandler().normalize(); 205 return convolverHandler().normalize();
206 } 206 }
207 207
208 void ConvolverNode::setNormalize(bool normalize) 208 void ConvolverNode::setNormalize(bool normalize)
209 { 209 {
210 convolverHandler().setNormalize(normalize); 210 convolverHandler().setNormalize(normalize);
211 } 211 }
212 212
213 } // namespace blink 213 } // namespace blink
214 214
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698