Make OAuth client id accessible to new ui w/o hardcoding

Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/e02bb087183bbf2323a0229eda4266b51d5d74d6

[kjlubick, 2016-08-11 19:34:24]

The CQ bit was checked by kjlubick@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 19:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:34:33]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[kjlubick, 2016-08-11 19:36:35]

Description was changed from

==========
Make OAuth client id accessible to new ui w/o hardcoding

BUG=
==========

to

==========
Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=
==========

[kjlubick, 2016-08-11 19:37:08]

Description was changed from

==========
Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=
==========

to

==========
Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=631047
==========

[kjlubick, 2016-08-11 19:37:09]

kjlubick@google.com changed reviewers:
+ vadimsh@chromium.org

[Vadim Sh., 2016-08-11 20:00:25]

most lg, few nits

Alternatively, I think, you may generate a JS snipped and include it from all
(static) pages, e.g.

/newui/client_id.js:

<script>
var client_id = "{{client_id}}";
</script>

index.html:

...
<script src="/newui/client_id.js"></script>
...

(Though I have no idea how then to plug client_id into Polymer stuff).

It should be faster than API endpoint, this the browser will do it before fully
loading or executing the page.

(And it can be heavily cached too).

One advantage, it that we will continue to serve main page as a static assets
(using GAE's static file service path, which implements caching and stuff
already).

But approach with templates is good too.

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_frontend.py (right):

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_frontend.py:745: 
nit: one more newline

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/prot...
File appengine/swarming/proto/config.proto (right):

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/prot...
appengine/swarming/proto/config.proto:35: optional string ui_client_id = 9;
add a comment explaining what it is and (briefly) how to get it

[Vadim Sh., 2016-08-11 20:01:05]

On 2016/08/11 20:00:25, Vadim Sh. wrote:
> most lg, few nits
> 
> Alternatively, I think, you may generate a JS snipped and include it from all
> (static) pages, e.g.
> 
> /newui/client_id.js:
> 
> <script>
> var client_id = "{{client_id}}";
> </script>
> 
> index.html:
> 
> ...
> <script src="/newui/client_id.js"></script>
> ...
> 
> (Though I have no idea how then to plug client_id into Polymer stuff).
> 
> It should be faster than API endpoint, this the browser will do it before
fully
> loading or executing the page.
> 
> (And it can be heavily cached too).
> 
> One advantage, it that we will continue to serve main page as a static assets
> (using GAE's static file service path, which implements caching and stuff
> already).
> 
> But approach with templates is good too.
> 
>
https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
> File appengine/swarming/handlers_frontend.py (right):
> 
>
https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
> appengine/swarming/handlers_frontend.py:745: 
> nit: one more newline
> 
>
https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/prot...
> File appengine/swarming/proto/config.proto (right):
> 
>
https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/prot...
> appengine/swarming/proto/config.proto:35: optional string ui_client_id = 9;
> add a comment explaining what it is and (briefly) how to get it

(sorry for typos in my reply...)

[kjlubick, 2016-08-11 20:11:34]

That idea to create a separate JS file is a good one.  If it turns out the extra
file request is faster than the templating of the index files, we should go with
it.

As far as piping it into Polymer with the separate JS file, that "shouldn't" be
too hard.

    document.elementById("#app").client_id = "{{client_id}}";

and Polymer should take care of the rest.

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
File appengine/swarming/handlers_frontend.py (right):

https://codereview.chromium.org/2242543002/diff/20001/appengine/swarming/hand...
appengine/swarming/handlers_frontend.py:745: 
On 2016/08/11 at 20:00:24, Vadim Sh. wrote:
> nit: one more newline

Done.

[Vadim Sh., 2016-08-11 20:13:06]

lgtm

[kjlubick, 2016-08-11 20:13:28]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-08-11 20:13:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 20:16:55]

Description was changed from

==========
Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=631047
==========

to

==========
Make OAuth client id accessible to new ui w/o hardcoding

The (small) index.html for each ui page will be turned 
into a template with one param - client_id 

My first try was to make an API endpoint, but that was
very very slow, because we had to wait for the api to
return (1-3 seconds) before making any other requests.
This is zippy and could be memcached, if needed.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/e02bb087183bbf2323a0229eda4266b51d5d74d6
==========

[commit-bot: I haz the power, 2016-08-11 20:16:56]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/e02bb087183bbf2323a0229eda4266b51d5d74d6