Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1961)

Unified Diff: appengine/swarming/elements/build/elements.html

Issue 2242543002: Make OAuth client id accessible to new ui w/o hardcoding (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: Address nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/swarming/elements/botlist-index.html ('k') | appengine/swarming/elements/index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/swarming/elements/build/elements.html
diff --git a/appengine/swarming/elements/build/elements.html b/appengine/swarming/elements/build/elements.html
index 2fc78ef346c57309f55aab5fe12c4304f953669b..f540c748c3a2093b69088909af11bd910742effc 100644
--- a/appengine/swarming/elements/build/elements.html
+++ b/appengine/swarming/elements/build/elements.html
@@ -14583,8 +14583,7 @@ You can bind to `isAuthorized` property to monitor authorization state.
<a class="left" href="/newui/">Home</a>
<a class="left" href="/newui/botlist">Bot List</a>
<div class="flex"></div>
-
- <auth-signin class="right" client-id="20770472288-t5smpbpjptka4nd888fv0ctd23ftba2o.apps.googleusercontent.com" auth-headers="{{auth_headers}}" signed-in="{{signed_in}}">
+ <auth-signin class="right" client-id="[[client_id]]" auth-headers="{{auth_headers}}" signed-in="{{signed_in}}">
</auth-signin>
</app-toolbar>
</app-header>
@@ -14598,6 +14597,9 @@ You can bind to `isAuthorized` property to monitor authorization state.
Polymer({
is: 'swarming-app',
properties: {
+ client_id: {
+ type: String,
+ },
auth_headers: {
type: Object,
notify: true,
@@ -14636,7 +14638,7 @@ You can bind to `isAuthorized` property to monitor authorization state.
</style>
- <swarming-app auth_headers="{{auth_headers}}" name="Swarming" busy="[[busy]]">
+ <swarming-app client_id="[[client_id]]" auth_headers="{{auth_headers}}" name="Swarming" busy="[[busy]]">
<iron-ajax id="request" url="/_ah/api/swarming/v1/server/details" headers="[[auth_headers]]" handle-as="json" last-response="{{serverDetails}}" loading="{{busy}}">
</iron-ajax>
@@ -14653,6 +14655,10 @@ You can bind to `isAuthorized` property to monitor authorization state.
is: 'swarming-index',
properties: {
+ client_id: {
+ type: String,
+ },
+
auth_headers: {
type: Object,
observer: "signIn",
@@ -21601,7 +21607,7 @@ is separate from validation, and `allowed-pattern` does not affect how the input
}
</style>
- <swarming-app auth_headers="{{_auth_headers}}" signed_in="{{_signed_in}}" busy="[[_busy]]" name="Swarming Bot List">
+ <swarming-app client_id="[[client_id]]" auth_headers="{{_auth_headers}}" signed_in="{{_signed_in}}" busy="[[_busy]]" name="Swarming Bot List">
<h2 hidden$="[[_signed_in]]">You must sign in to see anything useful.</h2>
@@ -21857,6 +21863,10 @@ is separate from validation, and `allowed-pattern` does not affect how the input
properties: {
+ client_id: {
+ type: String,
+ },
+
_bots: {
type: Array,
},
« no previous file with comments | « appengine/swarming/elements/botlist-index.html ('k') | appengine/swarming/elements/index.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698