Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2242453002: Avoid planar YUV resources when one component EGL images are not supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: modify comment to explain the use of RGBA_8888 to trigger a driver workaround Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 68b894846bb0ff89ffbdd837869f1f4f0492aaf6..68bc91b9151b93de0a5f137123f83ed42ca86482 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -3593,6 +3593,9 @@ Capabilities GLES2DecoderImpl::GetCapabilities() {
feature_info_->feature_flags().oes_compressed_etc1_rgb8_texture;
caps.texture_format_etc1_npot =
caps.texture_format_etc1 && !workarounds().etc1_power_of_two_only;
+ caps.force_software_yuv_conversion =
no sievers 2016/08/24 22:39:18 nit: Instead of 'force_software_yuv_conversion' ma
Tobias Sargeant 2016/08/26 15:52:11 Done.
+ mailbox_manager()->UsesSync() &&
no sievers 2016/08/24 22:39:18 nit: can you put a comment to explain why we only
Tobias Sargeant 2016/08/26 15:52:11 Done.
+ workarounds().avoid_one_component_egl_images;
caps.texture_rectangle = feature_info_->feature_flags().arb_texture_rectangle;
caps.texture_usage = feature_info_->feature_flags().angle_texture_usage;
caps.texture_storage = feature_info_->feature_flags().ext_texture_storage;

Powered by Google App Engine
This is Rietveld 408576698