Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2242453002: Avoid planar YUV resources when one component EGL images are not supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: modify comment to explain the use of RGBA_8888 to trigger a driver workaround Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <stdio.h> 10 #include <stdio.h>
(...skipping 3575 matching lines...) Expand 10 before | Expand all | Expand 10 after
3586 caps.texture_format_bgra8888 = 3586 caps.texture_format_bgra8888 =
3587 feature_info_->feature_flags().ext_texture_format_bgra8888; 3587 feature_info_->feature_flags().ext_texture_format_bgra8888;
3588 caps.texture_format_dxt1 = 3588 caps.texture_format_dxt1 =
3589 feature_info_->feature_flags().ext_texture_format_dxt1; 3589 feature_info_->feature_flags().ext_texture_format_dxt1;
3590 caps.texture_format_dxt5 = 3590 caps.texture_format_dxt5 =
3591 feature_info_->feature_flags().ext_texture_format_dxt5; 3591 feature_info_->feature_flags().ext_texture_format_dxt5;
3592 caps.texture_format_etc1 = 3592 caps.texture_format_etc1 =
3593 feature_info_->feature_flags().oes_compressed_etc1_rgb8_texture; 3593 feature_info_->feature_flags().oes_compressed_etc1_rgb8_texture;
3594 caps.texture_format_etc1_npot = 3594 caps.texture_format_etc1_npot =
3595 caps.texture_format_etc1 && !workarounds().etc1_power_of_two_only; 3595 caps.texture_format_etc1 && !workarounds().etc1_power_of_two_only;
3596 caps.force_software_yuv_conversion =
no sievers 2016/08/24 22:39:18 nit: Instead of 'force_software_yuv_conversion' ma
Tobias Sargeant 2016/08/26 15:52:11 Done.
3597 mailbox_manager()->UsesSync() &&
no sievers 2016/08/24 22:39:18 nit: can you put a comment to explain why we only
Tobias Sargeant 2016/08/26 15:52:11 Done.
3598 workarounds().avoid_one_component_egl_images;
3596 caps.texture_rectangle = feature_info_->feature_flags().arb_texture_rectangle; 3599 caps.texture_rectangle = feature_info_->feature_flags().arb_texture_rectangle;
3597 caps.texture_usage = feature_info_->feature_flags().angle_texture_usage; 3600 caps.texture_usage = feature_info_->feature_flags().angle_texture_usage;
3598 caps.texture_storage = feature_info_->feature_flags().ext_texture_storage; 3601 caps.texture_storage = feature_info_->feature_flags().ext_texture_storage;
3599 caps.discard_framebuffer = 3602 caps.discard_framebuffer =
3600 feature_info_->feature_flags().ext_discard_framebuffer; 3603 feature_info_->feature_flags().ext_discard_framebuffer;
3601 caps.sync_query = feature_info_->feature_flags().chromium_sync_query; 3604 caps.sync_query = feature_info_->feature_flags().chromium_sync_query;
3602 3605
3603 caps.chromium_image_rgb_emulation = ChromiumImageNeedsRGBEmulation(); 3606 caps.chromium_image_rgb_emulation = ChromiumImageNeedsRGBEmulation();
3604 #if defined(OS_MACOSX) 3607 #if defined(OS_MACOSX)
3605 // This is unconditionally true on mac, no need to test for it at runtime. 3608 // This is unconditionally true on mac, no need to test for it at runtime.
(...skipping 14137 matching lines...) Expand 10 before | Expand all | Expand 10 after
17743 } 17746 }
17744 17747
17745 // Include the auto-generated part of this file. We split this because it means 17748 // Include the auto-generated part of this file. We split this because it means
17746 // we can easily edit the non-auto generated parts right here in this file 17749 // we can easily edit the non-auto generated parts right here in this file
17747 // instead of having to edit some template or the code generator. 17750 // instead of having to edit some template or the code generator.
17748 #include "base/macros.h" 17751 #include "base/macros.h"
17749 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h" 17752 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
17750 17753
17751 } // namespace gles2 17754 } // namespace gles2
17752 } // namespace gpu 17755 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698