Issue 2242413002: Stop using next_packet_sequence_number_length in QuicPacketCreator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2242413002: Stop using next_packet_sequence_number_length in QuicPacketCreator. (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)

Modified:
4 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@130098258

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop using next_packet_sequence_number_length in QuicPacketCreator. ENABLED FLAGS_quic_simple_packet_number_length_2. There's no functional change here. We rolled back FLAGS_quic_simple_packet_number_length because it didn't pick up the fix to b/29095779 cr/129995365 fixes that, so as that fix rolls out it's safe to turn FLAGS_quic_simple_packet_number_length on again. Merge internal change: 130113504 R=rch@chromium.org

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -27 lines)			Patch
M	net/quic/core/quic_connection.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/quic/core/quic_flags.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_flags.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/core/quic_packet_creator.cc	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	net/quic/core/quic_packet_creator_test.cc	View	12 chunks	+12 lines, -12 lines	0 comments	Download

Depends on Patchset:

Issue 2246203003 Patch 1

Dependent Patchsets:

Issue 2242143004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages