Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2242143004: chromium relnote: Making QuicTestClient reads mockable. (Closed)

Created:
4 years, 4 months ago by ramant (doing other things)
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@130113504
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromium relnote: Making QuicTestClient reads mockable. Internal relnote: Droping expired TTL correctly for outbound packets. When we switched to doing proper backend picking for UDP proxy sessions, we also stopped using ProcessPacket for outbound packets, but still left all the handling code in place, obfuscating the new code path. This CL removes the lingering code, applies TTL correctly on the outbound path. This also removes reaping connections during the outbound path or during write failures, but that simply means we only apply connection timeouts when getting new incoming traffic which seems sufficient. Not flag protected because it's a big messy change. Merge internal change: 130124951 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M net/tools/quic/test_tools/quic_test_client.h View 3 chunks +12 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +12 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
4 years, 4 months ago (2016-08-15 22:42:27 UTC) #1
Ryan Hamilton
4 years, 4 months ago (2016-08-15 23:25:19 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698