Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 2242323002: Revert of [chrome_elf] Big cleanup and removing dependencies that recently crept in. Part 1. (Closed)

Created:
4 years, 4 months ago by Avi (use Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
penny, robertshield
CC:
chromium-reviews, kalyank, sadrul, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chrome_elf] Big cleanup and removing dependencies that recently crept in. Part 1. (patchset #9 id:300001 of https://codereview.chromium.org/2183263003/ ) Reason for revert: Win7 Tests (dbg)(1) started failing. https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/51720 Excerpt from step 103, chrome_elf_unittests on Windows-7-SP1 chrome_elf_unittests on Windows-7-SP1 : [ RUN ] HookTest.IATHook Assertion failed: false, file c:\b\c\b\win\src\chrome_elf\hook_util\hook_util.cc, line 302 [43/49] HookTest.IATHook (TIMED OUT) Original issue's description: > [chrome_elf] Big cleanup and removing dependencies that recently crept in. PART 1. > > - Moving all crash related APIs into one place (and out of chrome_elf_main). > - Started to clean up external dependencies - starting with hook_utils. > - Removed dependency on base/win/iat_patch_function. > > BUG=631771 > > Committed: https://crrev.com/d2767f8b41a8f7f70bddbd0783a8ef27a9370e58 > Cr-Commit-Position: refs/heads/master@{#411982} TBR=robertshield@chromium.org,pennymac@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631771 Committed: https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643 Cr-Commit-Position: refs/heads/master@{#412026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -886 lines) Patch
M chrome_elf/BUILD.gn View 7 chunks +67 lines, -74 lines 0 comments Download
M chrome_elf/blacklist.gypi View 3 chunks +3 lines, -1 line 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_elf/blacklist/blacklist_interceptions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome_elf/blacklist/crashpad_helper.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome_elf/blacklist/crashpad_helper.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome_elf/chrome_elf.gyp View 3 chunks +7 lines, -31 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 1 chunk +103 lines, -16 lines 0 comments Download
M chrome_elf/chrome_elf_security.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome_elf/chrome_elf_security.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome_elf/crash/crash_helper.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome_elf/crash/crash_helper.cc View 1 chunk +0 lines, -177 lines 0 comments Download
M chrome_elf/elf_imports_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
D chrome_elf/hook_util/hook_util.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome_elf/hook_util/hook_util.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D chrome_elf/hook_util/test/hook_util_test.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome_elf/hook_util/test/hook_util_test_dll.h View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome_elf/hook_util/test/hook_util_test_dll.cc View 1 chunk +0 lines, -22 lines 0 comments Download
A chrome_elf/hook_util/thunk_getter.h View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome_elf/hook_util/thunk_getter.cc View 1 chunk +152 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Avi (use Gerrit)
Created Revert of [chrome_elf] Big cleanup and removing dependencies that recently crept in. Part 1.
4 years, 4 months ago (2016-08-15 20:07:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242323002/1
4 years, 4 months ago (2016-08-15 20:07:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 20:08:46 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 20:10:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e989fa84a2f1fd669b2a0b3a9badb6eae3a1643
Cr-Commit-Position: refs/heads/master@{#412026}

Powered by Google App Engine
This is Rietveld 408576698