Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2242213004: Fix a double free in CPDFSDK_PageView::IsValidAnnot(). (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 4 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix a double free in CPDFSDK_PageView::IsValidAnnot(). BUG=635848 Committed: https://pdfium.googlesource.com/pdfium/+/4674d957a7637da9d242ff1bdba73a078f99a171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
We can't create a unique_ptr to pass into ContainsValue(), because the unique_ptr will eventually get ...
4 years, 4 months ago (2016-08-16 20:54:31 UTC) #4
Wei Li
lgtm, thanks
4 years, 4 months ago (2016-08-16 23:53:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242213004/1
4 years, 4 months ago (2016-08-17 00:02:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 00:02:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/4674d957a7637da9d242ff1bdba73a078f99...

Powered by Google App Engine
This is Rietveld 408576698