Fix a double free in CPDFSDK_PageView::IsValidAnnot().

fpdfsdk/fsdk_mgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/fsdk_mgr.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 1015 matching lines @@
 #else   // PDF_ENABLE_XFA
   return GetPageIndexForStaticPDF();
 #endif  // PDF_ENABLE_XFA
 }
 
 bool CPDFSDK_PageView::IsValidAnnot(const CPDF_Annot* p) const {
   if (!p)
     return false;
 
   const auto& annots = m_pAnnotList->All();
-  std::unique_ptr<const CPDF_Annot> annot(p);
-  return pdfium::ContainsValue(annots, annot);
+  auto it = std::find_if(annots.begin(), annots.end(),
+                         [p](const std::unique_ptr<CPDF_Annot>& annot) {
+                           return annot.get() == p;
+                         });
+  return it != annots.end();
 }
 
 CPDFSDK_Annot* CPDFSDK_PageView::GetFocusAnnot() {
   CPDFSDK_Annot* pFocusAnnot = m_pSDKDoc->GetFocusAnnot();
   if (!pFocusAnnot)
     return nullptr;
 
   for (CPDFSDK_Annot* pAnnot : m_fxAnnotArray) {
     if (pAnnot == pFocusAnnot)
       return pAnnot;
   }
   return nullptr;
 }
 
 int CPDFSDK_PageView::GetPageIndexForStaticPDF() const {
 #ifdef PDF_ENABLE_XFA
   CPDF_Page* pPage = m_page->GetPDFPage();
 #else   // PDF_ENABLE_XFA
   CPDF_Page* pPage = m_page;
 #endif  // PDF_ENABLE_XFA
   CPDF_Dictionary* pDict = pPage->m_pFormDict;
   CPDF_Document* pDoc = m_pSDKDoc->GetPDFDocument();
   return (pDoc && pDict) ? pDoc->GetPageIndex(pDict->GetObjNum()) : -1;
 }