Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/interpreter/handler-table-builder.h

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/constant-array-builder.cc ('k') | src/interpreter/handler-table-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/handler-table-builder.h
diff --git a/src/interpreter/handler-table-builder.h b/src/interpreter/handler-table-builder.h
index eb923b9d1fce73f4dd384547d88e9ba13fd93059..26c45f4056651d1507e7af5a0b0ce46fffbdc255 100644
--- a/src/interpreter/handler-table-builder.h
+++ b/src/interpreter/handler-table-builder.h
@@ -21,11 +21,11 @@ namespace interpreter {
// A helper class for constructing exception handler tables for the interpreter.
class HandlerTableBuilder final BASE_EMBEDDED {
public:
- HandlerTableBuilder(Isolate* isolate, Zone* zone);
+ explicit HandlerTableBuilder(Zone* zone);
// Builds the actual handler table by copying the current values into a heap
// object. Any further mutations to the builder won't be reflected.
- Handle<HandlerTable> ToHandlerTable();
+ Handle<HandlerTable> ToHandlerTable(Isolate* isolate);
// Creates a new handler table entry and returns a {hander_id} identifying the
// entry, so that it can be referenced by below setter functions.
@@ -50,7 +50,6 @@ class HandlerTableBuilder final BASE_EMBEDDED {
HandlerTable::CatchPrediction catch_prediction_;
};
- Isolate* isolate_;
ZoneVector<Entry> entries_;
DISALLOW_COPY_AND_ASSIGN(HandlerTableBuilder);
« no previous file with comments | « src/interpreter/constant-array-builder.cc ('k') | src/interpreter/handler-table-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698