Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: src/interpreter/handler-table-builder.h

Issue 2242193002: [Interpreter] Avoid accessing Isolate from during bytecode generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@offheap_sourceposition
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/constant-array-builder.cc ('k') | src/interpreter/handler-table-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_ 5 #ifndef V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_
6 #define V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_ 6 #define V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_
7 7
8 #include "src/handles.h" 8 #include "src/handles.h"
9 #include "src/interpreter/bytecode-register.h" 9 #include "src/interpreter/bytecode-register.h"
10 #include "src/interpreter/bytecodes.h" 10 #include "src/interpreter/bytecodes.h"
11 #include "src/zone-containers.h" 11 #include "src/zone-containers.h"
12 12
13 namespace v8 { 13 namespace v8 {
14 namespace internal { 14 namespace internal {
15 15
16 class HandlerTable; 16 class HandlerTable;
17 class Isolate; 17 class Isolate;
18 18
19 namespace interpreter { 19 namespace interpreter {
20 20
21 // A helper class for constructing exception handler tables for the interpreter. 21 // A helper class for constructing exception handler tables for the interpreter.
22 class HandlerTableBuilder final BASE_EMBEDDED { 22 class HandlerTableBuilder final BASE_EMBEDDED {
23 public: 23 public:
24 HandlerTableBuilder(Isolate* isolate, Zone* zone); 24 explicit HandlerTableBuilder(Zone* zone);
25 25
26 // Builds the actual handler table by copying the current values into a heap 26 // Builds the actual handler table by copying the current values into a heap
27 // object. Any further mutations to the builder won't be reflected. 27 // object. Any further mutations to the builder won't be reflected.
28 Handle<HandlerTable> ToHandlerTable(); 28 Handle<HandlerTable> ToHandlerTable(Isolate* isolate);
29 29
30 // Creates a new handler table entry and returns a {hander_id} identifying the 30 // Creates a new handler table entry and returns a {hander_id} identifying the
31 // entry, so that it can be referenced by below setter functions. 31 // entry, so that it can be referenced by below setter functions.
32 int NewHandlerEntry(); 32 int NewHandlerEntry();
33 33
34 // Setter functions that modify certain values within the handler table entry 34 // Setter functions that modify certain values within the handler table entry
35 // being referenced by the given {handler_id}. All values will be encoded by 35 // being referenced by the given {handler_id}. All values will be encoded by
36 // the resulting {HandlerTable} class when copied into the heap. 36 // the resulting {HandlerTable} class when copied into the heap.
37 void SetTryRegionStart(int handler_id, size_t offset); 37 void SetTryRegionStart(int handler_id, size_t offset);
38 void SetTryRegionEnd(int handler_id, size_t offset); 38 void SetTryRegionEnd(int handler_id, size_t offset);
39 void SetHandlerTarget(int handler_id, size_t offset); 39 void SetHandlerTarget(int handler_id, size_t offset);
40 void SetPrediction(int handler_id, HandlerTable::CatchPrediction prediction); 40 void SetPrediction(int handler_id, HandlerTable::CatchPrediction prediction);
41 void SetContextRegister(int handler_id, Register reg); 41 void SetContextRegister(int handler_id, Register reg);
42 42
43 private: 43 private:
44 struct Entry { 44 struct Entry {
45 size_t offset_start; // Bytecode offset starting try-region. 45 size_t offset_start; // Bytecode offset starting try-region.
46 size_t offset_end; // Bytecode offset ending try-region. 46 size_t offset_end; // Bytecode offset ending try-region.
47 size_t offset_target; // Bytecode offset of handler target. 47 size_t offset_target; // Bytecode offset of handler target.
48 Register context; // Register holding context for handler. 48 Register context; // Register holding context for handler.
49 // Optimistic prediction for handler. 49 // Optimistic prediction for handler.
50 HandlerTable::CatchPrediction catch_prediction_; 50 HandlerTable::CatchPrediction catch_prediction_;
51 }; 51 };
52 52
53 Isolate* isolate_;
54 ZoneVector<Entry> entries_; 53 ZoneVector<Entry> entries_;
55 54
56 DISALLOW_COPY_AND_ASSIGN(HandlerTableBuilder); 55 DISALLOW_COPY_AND_ASSIGN(HandlerTableBuilder);
57 }; 56 };
58 57
59 } // namespace interpreter 58 } // namespace interpreter
60 } // namespace internal 59 } // namespace internal
61 } // namespace v8 60 } // namespace v8
62 61
63 #endif // V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_ 62 #endif // V8_INTERPRETER_HANDLER_TABLE_BUILDER_H_
OLDNEW
« no previous file with comments | « src/interpreter/constant-array-builder.cc ('k') | src/interpreter/handler-table-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698