Issue 2242183002: [Merge to M53] Fix a regression in the keyboard overlay go back/forward shortcuts

Issue 2242183002: [Merge to M53] Fix a regression in the keyboard overlay go back/forward shortcuts (Closed)

Created:
4 years, 4 months ago by afakhry

Modified:
4 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

[Merge to M53] Fix a regression in the keyboard overlay go back/forward shortcuts My earlier CL: https://codereview.chromium.org/2206823004 resulted in the removal of alt+left/right shortcuts. This CL fixes this regression. TBR=stevenjb@chromium.org BUG=633825 TEST=manually CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2237993002 Cr-Commit-Position: refs/heads/master@{#411729} (cherry picked from commit ccff19d515c4615b5d7d420245c85b8e1c92ef73) Committed: https://chromium.googlesource.com/chromium/src/+/a4341d7b5ba3821f2a05d9584c26287f8cca0915

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	chrome/browser/resources/chromeos/keyboard_overlay.js	View		2 chunks	+8 lines, -9 lines	0 comments	Download

Total messages: 3 (2 generated)

afakhry

4 years, 4 months ago (2016-08-15 16:27:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a4341d7b5ba3821f2a05d9584c26287f8cca0915 (presubmit successful).