Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2237993002: Fix a regression in the keyboard overlay go back/forward shortcuts (Closed)

Created:
4 years, 4 months ago by afakhry
Modified:
4 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regression in the keyboard overlay go back/forward shortcuts My earlier CL: https://codereview.chromium.org/2206823004 resulted in the removal of alt+left/right shortcuts. This CL fixes this regression. BUG=633825 TEST=manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ccff19d515c4615b5d7d420245c85b8e1c92ef73 Cr-Commit-Position: refs/heads/master@{#411729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.js View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
afakhry
Xiyuan, please review. Thank you!
4 years, 4 months ago (2016-08-11 18:29:07 UTC) #3
afakhry
Xiyuan is OOO today. Steven, can you please review?
4 years, 4 months ago (2016-08-12 18:00:48 UTC) #9
stevenjb
RS lgtm
4 years, 4 months ago (2016-08-12 18:46:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237993002/1
4 years, 4 months ago (2016-08-12 18:49:07 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 19:22:56 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 19:24:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccff19d515c4615b5d7d420245c85b8e1c92ef73
Cr-Commit-Position: refs/heads/master@{#411729}

Powered by Google App Engine
This is Rietveld 408576698