Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2242173007: Mark several color-profile-* layout tests as flaky. (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
Reviewers:
ericrk
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark several color-profile-* layout tests as flaky. The failure seems to occurs on Win10 only, but these tests already had entries and it was not possible to add a new Win10-specific entry. TBR=ericrk@chromium.org BUG=638843 Committed: https://crrev.com/1977238868c1fc98f16589afec06ea7f031f3333 Cr-Commit-Position: refs/heads/master@{#412776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242173007/1
4 years, 4 months ago (2016-08-18 08:41:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 09:58:07 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1977238868c1fc98f16589afec06ea7f031f3333 Cr-Commit-Position: refs/heads/master@{#412776}
4 years, 4 months ago (2016-08-18 09:59:49 UTC) #5
rjwright
4 years, 4 months ago (2016-08-19 00:58:23 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2254303003/ by rjwright@chromium.org.

The reason for reverting is: This syntax seems to have prevented
rebaseline-o-matic from rebaselining these tests

https://codereview.chromium.org/2254133003/

Let's allow them to be rebaselined, and re-mark as flaky if they still fail..

Powered by Google App Engine
This is Rietveld 408576698