CSS Motion Path: New names for properties

third_party/WebKit/Source/core/css/CSSProperties.in

Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index 24b8e3fd314d4718b8c14bd3e4c59b80d8a09ff2..375485ed4714b0e1f297672c81e3bee6eee77969 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -255,11 +255,14 @@ max-width interpolable, initial=initialMaxSize, converter=convertLengthMaxSizing
 min-height interpolable, initial=initialMinSize, converter=convertLengthSizing
 min-width interpolable, initial=initialMinSize, converter=convertLengthSizing
 mix-blend-mode type_name=blink::WebBlendMode, name_for_methods=BlendMode
-motion-offset interpolable, converter=convertLength
-motion-path converter=convertPathOrNone
-motion-rotation interpolable, converter=convertMotionRotation
+motion-offset alias_for=offset-distance
+motion-path alias_for=offset-path
+motion-rotation alias_for=offset-rotation
 object-fit type_name=ObjectFit
 object-position interpolable, converter=convertPosition
+offset-distance interpolable, converter=convertLength
+offset-path converter=convertPathOrNone
+offset-rotation interpolable, converter=convertOffsetRotation
 opacity interpolable, type_name=float
 order type_name=int
 orphans interpolable, inherited, type_name=short
@@ -498,7 +501,8 @@ grid-template runtime_flag=CSSGridLayout, longhands=grid-template-rows;grid-temp
 list-style longhands=list-style-type;list-style-position;list-style-image
 margin longhands=margin-top;margin-right;margin-bottom;margin-left
 marker longhands=marker-start;marker-mid;marker-end
-motion longhands=motion-path;motion-offset;motion-rotation
+motion longhands=offset-path;offset-distance;offset-rotation

[alancutter (OOO until 2018), 2016/09/19 00:49:54]

Can this be an alias for offset?

[suzyh_UTC10 (ex-contributor), 2016/09/19 01:21:04]

I think Alan's right, didn't we say we would make this a direct alias?

If not, since motion-* are aliases for the offset-* names, perhaps it would be a
good idea to leave the motion expansion with the motion-* names. That way we
leave open the option to diverge offset* and motion* without modifying this line
again.

[Eric Willigers, 2016/09/19 01:54:40]

I want more control during parsing that a direct alias of the shorthand would
allow. For example, I want to be able to add different use counters.

I would have been content to use
motion-path, motion-offset, motion-rotation
but that fails to build.

[suzyh_UTC10 (ex-contributor), 2016/09/19 03:32:30]

OK, sounds good. I wasn't sure if using aliases in the expansion would work.

Does your first statement mean that if motion-* are aliases (as you have
currently written) then we won't be able to have different use counters on
motion-* and on offset-*?

[Eric Willigers, 2016/09/19 04:46:14]

UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram
has separate entities for each name, so they should be use counted
separately.

motion: ... with a not-none path
is something that I would ideally like to count with
motion-path: ... with a not-none path
and not
offset-path: ... with a not-none path

but that is a complication for the future CL mentioned in this CL's description:
This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


Suggestions welcome, but they don't need to block this CL.

+offset longhands=offset-path;offset-distance;offset-rotation
 outline longhands=outline-color;outline-style;outline-width
 overflow longhands=overflow-x;overflow-y
 padding longhands=padding-top;padding-right;padding-bottom;padding-left