CSS Motion Path: New names for properties

third_party/WebKit/Source/core/css/CSSProperties.in

 // This file specifies all the CSS properties we support and the necessary
 // information for our code generation. The various supported arguments
 // are described below with example usage
 
 
 // - alias_for=other-property
 // Properties specifying alias_for should be virtually identical to the
 // properties they alias. Minor parsing differences are allowed as long as
 // the CSSValues created are of the same format of the aliased property.
 
@@ skipping 237 matching lines @@
 marker-mid inherited, svg, name_for_methods=MarkerMidResource, converter=convertFragmentIdentifier
 marker-start inherited, svg, name_for_methods=MarkerStartResource, converter=convertFragmentIdentifier
 mask svg, name_for_methods=MaskerResource, converter=convertFragmentIdentifier
 mask-source-type runtime_flag=CSSMaskSourceType, custom_all
 mask-type svg
 max-height interpolable, initial=initialMaxSize, converter=convertLengthMaxSizing
 max-width interpolable, initial=initialMaxSize, converter=convertLengthMaxSizing
 min-height interpolable, initial=initialMinSize, converter=convertLengthSizing
 min-width interpolable, initial=initialMinSize, converter=convertLengthSizing
 mix-blend-mode type_name=blink::WebBlendMode, name_for_methods=BlendMode
-motion-offset interpolable, converter=convertLength
-motion-path converter=convertPathOrNone
-motion-rotation interpolable, converter=convertMotionRotation
+motion-offset alias_for=offset-distance
+motion-path alias_for=offset-path
+motion-rotation alias_for=offset-rotation
 object-fit type_name=ObjectFit
 object-position interpolable, converter=convertPosition
+offset-distance interpolable, converter=convertLength
+offset-path converter=convertPathOrNone
+offset-rotation interpolable, converter=convertOffsetRotation
 opacity interpolable, type_name=float
 order type_name=int
 orphans interpolable, inherited, type_name=short
 outline-color interpolable, custom_all
 outline-offset interpolable, converter=convertComputedLength<int>
 outline-style custom_all
 outline-width interpolable, converter=convertLineWidth<unsigned short>
 overflow-anchor runtime_flag=ScrollAnchoring, type_name=EOverflowAnchor
 overflow-wrap inherited
 overflow-x type_name=EOverflow
@@ skipping 218 matching lines @@
 font-variant longhands=font-variant-ligatures;font-variant-caps;font-variant-numeric
 grid runtime_flag=CSSGridLayout, longhands=grid-template-rows;grid-template-columns;grid-template-areas;grid-auto-flow;grid-auto-rows;grid-auto-columns;grid-column-gap;grid-row-gap
 grid-area runtime_flag=CSSGridLayout, longhands=grid-row-start;grid-column-start;grid-row-end;grid-column-end
 grid-column runtime_flag=CSSGridLayout, longhands=grid-column-start;grid-column-end
 grid-gap runtime_flag=CSSGridLayout, longhands=grid-row-gap;grid-column-gap
 grid-row runtime_flag=CSSGridLayout, longhands=grid-row-start;grid-row-end
 grid-template runtime_flag=CSSGridLayout, longhands=grid-template-rows;grid-template-columns;grid-template-areas
 list-style longhands=list-style-type;list-style-position;list-style-image
 margin longhands=margin-top;margin-right;margin-bottom;margin-left
 marker longhands=marker-start;marker-mid;marker-end
-motion longhands=motion-path;motion-offset;motion-rotation
+motion longhands=offset-path;offset-distance;offset-rotation

[alancutter (OOO until 2018), 2016/09/19 00:49:54]

Can this be an alias for offset?

[suzyh_UTC10 (ex-contributor), 2016/09/19 01:21:04]

I think Alan's right, didn't we say we would make this a direct alias?

If not, since motion-* are aliases for the offset-* names, perhaps it would be a
good idea to leave the motion expansion with the motion-* names. That way we
leave open the option to diverge offset* and motion* without modifying this line
again.

[Eric Willigers, 2016/09/19 01:54:40]

I want more control during parsing that a direct alias of the shorthand would
allow. For example, I want to be able to add different use counters.

I would have been content to use
motion-path, motion-offset, motion-rotation
but that fails to build.

[suzyh_UTC10 (ex-contributor), 2016/09/19 03:32:30]

OK, sounds good. I wasn't sure if using aliases in the expansion would work.

Does your first statement mean that if motion-* are aliases (as you have
currently written) then we won't be able to have different use counters on
motion-* and on offset-*?

[Eric Willigers, 2016/09/19 04:46:14]

UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram
has separate entities for each name, so they should be use counted
separately.

motion: ... with a not-none path
is something that I would ideally like to count with
motion-path: ... with a not-none path
and not
offset-path: ... with a not-none path

but that is a complication for the future CL mentioned in this CL's description:
This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


Suggestions welcome, but they don't need to block this CL.

+offset longhands=offset-path;offset-distance;offset-rotation
 outline longhands=outline-color;outline-style;outline-width
 overflow longhands=overflow-x;overflow-y
 padding longhands=padding-top;padding-right;padding-bottom;padding-left
 page-break-after longhands=break-after
 page-break-before longhands=break-before
 page-break-inside longhands=break-inside
 transition longhands=transition-property;transition-duration;transition-timing-function;transition-delay
 -webkit-border-after longhands=-webkit-border-after-width;-webkit-border-after-style;-webkit-border-after-color
 -webkit-border-before longhands=-webkit-border-before-width;-webkit-border-before-style;-webkit-border-before-color
 -webkit-border-end longhands=-webkit-border-end-width;-webkit-border-end-style;-webkit-border-end-color
@@ skipping 75 matching lines @@
 -webkit-text-size-adjust alias_for=text-size-adjust
 -webkit-transform alias_for=transform
 -webkit-transform-origin alias_for=transform-origin
 -webkit-transform-style alias_for=transform-style
 -webkit-transition alias_for=transition
 -webkit-transition-delay alias_for=transition-delay
 -webkit-transition-duration alias_for=transition-duration
 -webkit-transition-property alias_for=transition-property
 -webkit-transition-timing-function alias_for=transition-timing-function
 -webkit-user-select alias_for=user-select