CSS Motion Path: New names for properties

CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

This patch doesn't include deprecation warnings for the old names, or the extra use counter for not-none motion-path discussed in the Intent To Ship.

This patch also doesn't include any of the additional options the spec provides for offset-path (<angle> [contain]) or offset-distance (closest-side / farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)

BUG=637543
Committed: https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1
Cr-Commit-Position: refs/heads/master@{#419710}

[Eric Willigers, 2016-08-13 12:48:01]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-13 12:48:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 12:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 12:57:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Eric Willigers, 2016-08-14 12:08:23]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 12:08:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-08-14 12:08:34]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-14 13:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-14 13:09:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eric Willigers, 2016-08-14 23:08:37]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-14 23:08:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 00:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 00:39:33]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-09-16 06:36:21]

Description was changed from

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

This patch doesn't include any of the additional options the spec provides for
offset-path (<angle> [contain]) or offset-distance (closest-side / farthest-side
/ closest-corner / farthest-corner).

BUG=637543
==========

to

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1Mb...

This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


This patch also doesn't include any of the additional options the spec provides
for offset-path (<angle> [contain]) or offset-distance (closest-side /
farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)
 
BUG=637543
==========

[Eric Willigers, 2016-09-16 06:36:21]

ericwilligers@chromium.org changed reviewers:
+ alancutter@chromium.org, suzyh@chromium.org, timloh@chromium.org

[Eric Willigers, 2016-09-16 06:36:39]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 06:36:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 08:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 08:12:43]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-09-19 00:49:54]

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/motion-path/offset.html (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:15: }
These tests would be easier to read if the offset was set on inline style in
Javascript next to the code that asserts on the computed style rather than using
div# associations.
Ditto for the other new offset-*.html tests.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:504: motion
longhands=offset-path;offset-distance;offset-rotation
Can this be an alias for offset?

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:3029: 
No need for extra newline.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StyleMotionData.h (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StyleMotionData.h:11: #include
"platform/LengthPoint.h"
Is this include necessary?

[suzyh_UTC10 (ex-contributor), 2016-09-19 01:21:04]

For future: I would recommend making separate patches for the user-visible
change (the addition of the aliased names) and the code health renaming aspect.
That would make it possible to roll back and reland the user-visible change if
necessary, without having to re-review the extensive internal renaming. While I
won't block this patch on splitting them up, if this is going to require another
round of review, consider splitting it up anyway to make further reviews easier.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/motion-path/offset.html (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:1: <!DOCTYPE html>
I'm surprised these tests didn't already exist for motion-*. So long as the
motion names exist, should we copy these tests for motion-* as well?

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:504: motion
longhands=offset-path;offset-distance;offset-rotation
I think Alan's right, didn't we say we would make this a direct alias?

If not, since motion-* are aliases for the offset-* names, perhaps it would be a
good idea to leave the motion expansion with the motion-* names. That way we
leave open the option to diverge offset* and motion* without modifying this line
again.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:992: case
CSSPropertyOffsetPath:
Is this introducing a behaviour change?

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.h (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.h:973: // offset-distance
Should these be moved down after object* to maintain alphabetical order?

[Eric Willigers, 2016-09-19 01:54:41]

I changed the following files in response to review comments:
ComputedStyleCSSValueMapping.cpp
ComputedStyle.cpp
ComputedStyle.h
StyleMotionData.h

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/motion-path/offset.html (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:1: <!DOCTYPE html>
On 2016/09/19 01:21:04, suzyh wrote:
> I'm surprised these tests didn't already exist for motion-*. So long as the
> motion names exist, should we copy these tests for motion-* as well?

I am copying the existing tests. 
motion-path.html is copied to offset-path.html
motion-offset.html is copied to offset-distance.html
motion-rotation.html is copied to offset-rotation.html

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:15: }
On 2016/09/19 00:49:54, alancutter wrote:
> These tests would be easier to read if the offset was set on inline style in
> Javascript next to the code that asserts on the computed style rather than
using
> div# associations.
> Ditto for the other new offset-*.html tests.

Sure, I can refactor when adding new tests. For this CL, it is easier to review
if they exactly match the existing motion tests.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:504: motion
longhands=offset-path;offset-distance;offset-rotation

I want more control during parsing that a direct alias of the shorthand would
allow. For example, I want to be able to add different use counters.

I would have been content to use
motion-path, motion-offset, motion-rotation
but that fails to build.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:3029: 
On 2016/09/19 00:49:54, alancutter wrote:
> No need for extra newline.

Done.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:992: case
CSSPropertyOffsetPath:
On 2016/09/19 01:21:04, suzyh wrote:
> Is this introducing a behaviour change?

Bug fix, can move to a separate CL.

https://drafts.fxtf.org/motion-1/#offset-path-property
"A computed value of other than none results in the creation of a stacking
context [CSS21] the same way that CSS opacity [CSS3COLOR] does for values other
than 1, unless the element is an SVG element without an associated CSS layout
box."

So
will-change: offset-path
should be treated the same as
will-change: opacity

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/StyleMotionData.h (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/StyleMotionData.h:11: #include
"platform/LengthPoint.h"
On 2016/09/19 00:49:54, alancutter wrote:
> Is this include necessary?

Removed for now. Will add again when we support offset-position and
offset-anchor.

[suzyh_UTC10 (ex-contributor), 2016-09-19 03:32:30]

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/motion-path/offset.html (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:1: <!DOCTYPE html>
On 2016/09/19 at 01:54:40, Eric Willigers wrote:
> On 2016/09/19 01:21:04, suzyh wrote:
> > I'm surprised these tests didn't already exist for motion-*. So long as the
> > motion names exist, should we copy these tests for motion-* as well?
> 
> I am copying the existing tests. 
> motion-path.html is copied to offset-path.html
> motion-offset.html is copied to offset-distance.html
> motion-rotation.html is copied to offset-rotation.html

Oh, codereview just showed them up as completely new files. Never mind then.

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:504: motion
longhands=offset-path;offset-distance;offset-rotation
On 2016/09/19 at 01:54:40, Eric Willigers wrote:
> I want more control during parsing that a direct alias of the shorthand would
allow. For example, I want to be able to add different use counters.
> 
> I would have been content to use
> motion-path, motion-offset, motion-rotation
> but that fails to build.

OK, sounds good. I wasn't sure if using aliases in the expansion would work.

Does your first statement mean that if motion-* are aliases (as you have
currently written) then we won't be able to have different use counters on
motion-* and on offset-*?

https://codereview.chromium.org/2241993002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html
(right):

https://codereview.chromium.org/2241993002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html:39:
offset-path: path('M400,0');
If adding offset-path to hasPropertyThatCreatesStackingContext was a bug fix
that changed behaviour, why was this test (which I expect, based on the name, is
related) unaffected? Does this test actually test what it's supposed to test?

[alancutter (OOO until 2018), 2016-09-19 04:20:02]

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/css3/motion-path/offset.html (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/css3/motion-path/offset.html:15: }
On 2016/09/19 at 01:54:40, Eric Willigers wrote:
> On 2016/09/19 00:49:54, alancutter wrote:
> > These tests would be easier to read if the offset was set on inline style in
> > Javascript next to the code that asserts on the computed style rather than
using
> > div# associations.
> > Ditto for the other new offset-*.html tests.
> 
> Sure, I can refactor when adding new tests. For this CL, it is easier to
review if they exactly match the existing motion tests.

Ah, didn't realise this was a copy + rename. Nevermind then, better to keep it
simple and fix code health in separate patches.

[Eric Willigers, 2016-09-19 04:46:14]

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2241993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSProperties.in:504: motion
longhands=offset-path;offset-distance;offset-rotation
On 2016/09/19 03:32:30, suzyh wrote:
> On 2016/09/19 at 01:54:40, Eric Willigers wrote:
> > I want more control during parsing that a direct alias of the shorthand
would
> allow. For example, I want to be able to add different use counters.
> > 
> > I would have been content to use
> > motion-path, motion-offset, motion-rotation
> > but that fails to build.
> 
> OK, sounds good. I wasn't sure if using aliases in the expansion would work.
> 
> Does your first statement mean that if motion-* are aliases (as you have
> currently written) then we won't be able to have different use counters on
> motion-* and on offset-*?

UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram
has separate entities for each name, so they should be use counted
separately.

motion: ... with a not-none path
is something that I would ideally like to count with
motion-path: ... with a not-none path
and not
offset-path: ... with a not-none path

but that is a complication for the future CL mentioned in this CL's description:
This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


Suggestions welcome, but they don't need to block this CL.

https://codereview.chromium.org/2241993002/diff/100001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html
(right):

https://codereview.chromium.org/2241993002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/css3/motion-path/path-establishes-stacking-context.html:39:
offset-path: path('M400,0');
On 2016/09/19 03:32:30, suzyh wrote:
> If adding offset-path to hasPropertyThatCreatesStackingContext was a bug fix
> that changed behaviour, why was this test (which I expect, based on the name,
is
> related) unaffected? Does this test actually test what it's supposed to test?

hasPropertyThatCreatesStackingContext is about will-change.

https://dev.opera.com/articles/css-will-change-property/
https://developer.mozilla.org/en/docs/Web/CSS/will-change
https://drafts.csswg.org/css-will-change/
If any non-initial value of a property would create a stacking context on the
element, specifying that property in will-change must create a stacking context
on the element.


The idea is that 

div1 {
  will-change: offset-path;
  offset-path: none;
}

should create a stacking context.



As for this test's effectiveness, I've included the question in crbug.com/648113

In this CL, we are simply migrating the existing test to the new name.

[suzyh_UTC10 (ex-contributor), 2016-09-19 05:19:38]

lgtm, thanks

[alancutter (OOO until 2018), 2016-09-19 05:33:58]

lgtm

[Eric Willigers, 2016-09-19 05:59:05]

ericwilligers@chromium.org changed reviewers:
+ jochen@chromium.org, sigbjornf@opera.com

[Eric Willigers, 2016-09-19 05:59:06]

+ sigbjornf@opera.com for core/frame OWNERS
+ jochen@chromium.org for UseCounter histogram OWNERS

[jochen (gone - plz use gerrit), 2016-09-19 14:29:44]

as you're changing histograms and not just adding, I'll defer to an actual
metrics owner, sorry (tools/metrics/OWNERS)

[Eric Willigers, 2016-09-19 19:06:59]

ericwilligers@chromium.org changed reviewers:
+ mpearson@chromium.org
- jochen@chromium.org

[Eric Willigers, 2016-09-19 19:07:00]

+mpearson for tools/metrics OWNERS

[Mark P, 2016-09-19 19:36:19]

histograms.xml lgtm

[Eric Willigers, 2016-09-20 01:34:06]

ericwilligers@chromium.org changed reviewers:
+ dstockwell@chromium.org

[sashab, 2016-09-20 04:42:19]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2016-09-20 04:42:20]

In future, when most of a patch is find-and-replace, maybe mention that
somewhere :)

I would have done the method renames separately, but this is fine. style/ and
css/ LGTM.

[dstockwell, 2016-09-20 04:43:48]

lgtm

[Eric Willigers, 2016-09-20 04:51:29]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 04:51:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 06:22:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 06:22:39]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-09-20 06:28:30]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-09-20 06:28:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 06:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 06:37:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eric Willigers, 2016-09-20 06:47:33]

ericwilligers@chromium.org changed reviewers:
+ jochen@chromium.org

[Eric Willigers, 2016-09-20 06:47:34]

+jochen for API_OWNERS

[jochen (gone - plz use gerrit), 2016-09-20 09:42:00]

lgtm

[Eric Willigers, 2016-09-20 09:51:08]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:51:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:57:33]

Description was changed from

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1Mb...

This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


This patch also doesn't include any of the additional options the spec provides
for offset-path (<angle> [contain]) or offset-distance (closest-side /
farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)
 
BUG=637543
==========

to

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1Mb...

This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


This patch also doesn't include any of the additional options the spec provides
for offset-path (<angle> [contain]) or offset-distance (closest-side /
farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)
 
BUG=637543
==========

[commit-bot: I haz the power, 2016-09-20 09:57:35]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-09-20 09:59:05]

Description was changed from

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1Mb...

This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.


This patch also doesn't include any of the additional options the spec provides
for offset-path (<angle> [contain]) or offset-distance (closest-side /
farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)
 
BUG=637543
==========

to

==========
CSS Motion Path: New names for properties

The CSS property names for Motion Path properties have changed.

Recent spec update:
https://drafts.fxtf.org/motion-1/
https://github.com/w3c/fxtf-drafts/pull/14

As we already shipped with the earlier names, we alias them to the new names.

motion-offset -> offset-distance
motion-path -> offset-path
motion-rotation -> offset-rotation
motion -> offset

Intent To Ship
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1Mb...

This patch doesn't include deprecation warnings for the old names, or the extra
use counter for not-none motion-path discussed in the Intent To Ship.

This patch also doesn't include any of the additional options the spec provides
for offset-path (<angle> [contain]) or offset-distance (closest-side /
farthest-side / closest-corner / farthest-corner).
(They will be implemented behind a flag, for a future Intent to Ship.)

BUG=637543

Committed: https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1
Cr-Commit-Position: refs/heads/master@{#419710}
==========

[commit-bot: I haz the power, 2016-09-20 09:59:07]

Patchset 5 (id:??) landed as
https://crrev.com/ba9dc4f32ee4a0a29ab99be8274e2605998d14b1
Cr-Commit-Position: refs/heads/master@{#419710}