Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2241973002: Reland of Fail builds when lint warnings are generated. (Closed)

Created:
4 years, 4 months ago by agrieve
Modified:
4 years, 4 months ago
Reviewers:
caseq, estevenson
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #2 of Fail builds when lint warnings are generated Previous: https://codereview.chromium.org/2236313004/ Reason for revert: If this fails again, please revert changes that introduce new warnings rather than this patch. TBR=estevenson@chromium.org,caseq@chromium.org BUG=607761 Committed: https://crrev.com/f8bde5d301337c0994a9d71fc31ed71b36a26e47 Cr-Commit-Position: refs/heads/master@{#411864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -66 lines) Patch
M build/android/gyp/lint.py View 1 chunk +4 lines, -1 line 0 comments Download
M build/android/lint/suppressions.xml View 1 chunk +198 lines, -65 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
agrieve
Created Reland of Fail builds when lint warnings are generated.
4 years, 4 months ago (2016-08-13 01:46:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241973002/1
4 years, 4 months ago (2016-08-13 01:47:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 02:42:23 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8bde5d301337c0994a9d71fc31ed71b36a26e47 Cr-Commit-Position: refs/heads/master@{#411864}
4 years, 4 months ago (2016-08-13 02:46:53 UTC) #8
agrieve
4 years, 4 months ago (2016-08-13 03:44:46 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2241833003/ by agrieve@chromium.org.

The reason for reverting is: Broke clank tot roller:
https://uberchromegw.corp.google.com/i/internal.client.clank_tot/builders/cla...
.

Powered by Google App Engine
This is Rietveld 408576698