Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/lint/suppressions.xml

Issue 2241973002: Reland of Fail builds when lint warnings are generated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/lint/suppressions.xml
diff --git a/build/android/lint/suppressions.xml b/build/android/lint/suppressions.xml
index 2111f9a5c2023a79732dc81c08882477dbae3136..fa503d680945d4d33d0ddd613a0eb93511bb0dca 100644
--- a/build/android/lint/suppressions.xml
+++ b/build/android/lint/suppressions.xml
@@ -22,105 +22,238 @@
directory path (e.g. out/Debug)
-->
<issue id="AllowBackup">
- <ignore path="AndroidManifest.xml"/>
- </issue>
- <issue id="Assert" severity="ignore"/>
+ <ignore path="AndroidManifest.xml" />
+ </issue>
+ <issue id="Assert" severity="ignore" />
+ <issue id="ButtonOrder" severity="Error">
+ <ignore regexp="chrome/android/java/res/layout/homepage_editor.xml" />
+ </issue>
+ <issue id="ButtonStyle" severity="Error">
+ <ignore regexp="remoting/android/host/res/layout/main.xml" />
+ </issue>
<issue id="CommitPrefEdits">
- <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidChannelPreferences.java"/>
+ <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/ticl/android2/channel/AndroidChannelPreferences.java" />
+ </issue>
+ <issue id="ContentDescription" severity="Error">
+ <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" />
</issue>
<issue id="DefaultLocale">
- <ignore path="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/external/client/contrib/AndroidListenerState.java"/>
+ <ignore regexp="third_party/cacheinvalidation/src/java/com/google/ipc/invalidation/external/client/contrib/AndroidListenerState.java" />
</issue>
<issue id="DrawAllocation">
- <ignore path="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java"/>
- <ignore path="content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java"/>
+ <ignore regexp="content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java" />
+ <ignore regexp="content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java" />
</issue>
<issue id="ExportedContentProvider">
- <ignore path="AndroidManifest.xml"/>
+ <ignore path="AndroidManifest.xml" />
+ </issue>
+ <issue id="ExportedService" severity="Error">
+ <ignore regexp="AndroidManifest.xml" />
</issue>
<issue id="HandlerLeak">
- <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java"/>
- </issue>
- <issue id="IconMissingDensityFolder">
- <!-- see crbug.com/542435 -->
- <ignore path="android_webview/apk/java/res" />
+ <ignore regexp="android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java" />
+ <ignore regexp="remoting/android/java/src/org/chromium/chromoting/TapGestureDetector.java" />
+ </issue>
+ <issue id="HardcodedDebugMode" severity="Fatal">
+ <ignore path="AndroidManifest.xml" />
+ </issue>
+ <issue id="HardcodedText" severity="Error">
+ <ignore regexp="remoting/android/host/res/layout/main.xml" />
+ </issue>
+ <issue id="IconColors" severity="Error">
+ <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-hdpi/notification_icon.png" />
+ <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-mdpi/notification_icon.png" />
+ <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xhdpi/notification_icon.png" />
+ <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxhdpi/notification_icon.png" />
+ <ignore regexp="tools/android/audio_focus_grabber/java/res/drawable-xxxhdpi/notification_icon.png" />
</issue>
<issue id="IconDensities">
<!-- crbug.com/457918 is tracking missing assets -->
- <ignore path="components/web_contents_delegate_android/android/java/res/drawable-xxhdpi"/>
- <ignore path="components/web_contents_delegate_android/android/java/res/drawable-xxxhdpi"/>
- <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
- <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
- <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
- <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
- <ignore path="ui/android/java/res/drawable-xxhdpi"/>
- <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
+ <ignore regexp="components/web_contents_delegate_android/android/java/res/drawable-xxhdpi" />
+ <ignore regexp="components/web_contents_delegate_android/android/java/res/drawable-xxxhdpi" />
+ <ignore regexp="content/public/android/java/res/drawable-xxhdpi" />
+ <ignore regexp="content/public/android/java/res/drawable-xxxhdpi" />
+ <ignore regexp="chrome/android/java/res/drawable-xxhdpi" />
+ <ignore regexp="chrome/android/java/res/drawable-xxxhdpi" />
+ <ignore regexp="ui/android/java/res/drawable-xxhdpi" />
+ <ignore regexp="ui/android/java/res/drawable-xxxhdpi" />
<!-- The large assets below only include a few densities to reduce APK size. -->
- <ignore regexp=".*: data_reduction_illustration.png, google_icon_sprite.png, physical_web_logo.png, physical_web_logo_anim1.png, physical_web_logo_anim2.png$"/>
+ <ignore regexp=": data_reduction_illustration.png, google_icon_sprite.png, physical_web_logo.png, physical_web_logo_anim1.png, physical_web_logo_anim2.png$" />
</issue>
<issue id="IconDipSize">
- <ignore regexp=".*google_icon_sprite.png.*"/>
+ <ignore regexp="google_icon_sprite.png.*" />
</issue>
<issue id="IconLocation">
<!-- It is OK for content_shell_apk to have missing assets. -->
- <ignore path="content/shell/android/java/res/"/>
+ <ignore regexp="content/shell/android/java/res/" />
<!-- Suppression for chrome/test/chromedriver/test/webview_shell/java/res/drawable/icon.png -->
- <ignore path="res/drawable/icon.png"/>
+ <ignore regexp="res/drawable/icon.png" />
<!-- TODO(lambroslambrou) remove this once crbug.com/502030 is fixed. -->
- <ignore path="remoting/android/java/res"/>
- </issue>
- <issue id="InconsistentLayout" severity="ignore"/>
- <issue id="InflateParams" severity="ignore"/>
- <issue id="LongLogTag" severity="ignore"/>
- <issue id="MissingApplicationIcon" severity="ignore"/>
- <issue id="MissingPermission" severity="ignore"/>
- <issue id="MissingRegistered" severity="ignore"/>
+ <ignore regexp="remoting/android/java/res" />
+ </issue>
+ <issue id="IconMissingDensityFolder">
+ <ignore regexp="android_webview/tools/system_webview_shell/apk/res" />
+ <ignore regexp="chrome/android/webapk/shell_apk/res" />
+ <ignore regexp="tools/android/push_apps_to_background/res" />
+ <!-- see crbug.com/542435 -->
+ <ignore regexp="android_webview/apk/java/res" />
+ </issue>
+ <issue id="ImpliedQuantity" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-fa/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml" />
+ </issue>
+ <issue id="InconsistentArrays" severity="Error">
+ <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale-paks.xml" />
+ <ignore regexp="gen/chrome/android/chrome_locale_paks.resources.zip/values/locale-paks.xml" />
+ </issue>
+ <issue id="InconsistentLayout" severity="ignore" />
+ <issue id="InefficientWeight" severity="Error">
+ <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml" />
+ </issue>
+ <issue id="InflateParams" severity="ignore" />
+ <issue id="InlinedApi" severity="ignore" />
+ <issue id="LabelFor" severity="Error">
+ <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml" />
+ </issue>
+ <issue id="LintError" severity="Error" />
+ <issue id="LogConditional" severity="ignore" />
+ <issue id="LongLogTag" severity="ignore" />
+ <issue id="MissingApplicationIcon" severity="ignore" />
+ <issue id="MissingPermission" severity="ignore" />
+ <issue id="MissingRegistered" severity="ignore" />
+ <issue id="MissingSuperCall" severity="Error">
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectionToolbar.java" />
+ </issue>
<issue id="MissingTranslation">
+ <ignore regexp="blimp/client/app/android/java/res/values/arrays.xml" />
<!-- http://crbug.com/450548 -->
- <ignore regexp=".*restriction_values.xml.*" />
+ <ignore regexp="restriction_values.xml.*" />
</issue>
<issue id="MissingVersion">
- <ignore path="AndroidManifest.xml"/>
- </issue>
- <issue id="InlinedApi" severity="ignore"/>
+ <ignore path="AndroidManifest.xml" />
+ </issue>
<issue id="NewApi">
- <ignore regexp="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17"/>
- <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/>
- <ignore path="org/chromium/base/JavaHandlerThread.class"/>
- <ignore path="org/chromium/base/SysUtils.class"/>
- <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/>
- <ignore path="org/chromium/chrome/browser/TtsPlatformImpl$*.class"/>
- <ignore path="chrome/android/java/res/values-v17/styles.xml"/>
+ <ignore regexp="com/chrome/cloud/experimental/airspeed/BenchmarksTest.class" />
+ <ignore regexp="org/chromium/memconsumer/MemConsumer.*.class" />
+ <ignore regexp="org/chromium/memconsumer/ResidentService.class" />
+ <ignore regexp="org/chromium/mojo/bindings/ValidationTest.class" />
+ <ignore regexp="chrome/android/java/res/values-v17/styles.xml" />
+ <ignore regexp="org/chromium/base/AnimationFrameTimeHistogram.*Recorder.class" />
+ <ignore regexp="org/chromium/base/JavaHandlerThread.class" />
+ <ignore regexp="org/chromium/base/SysUtils.class" />
+ <ignore regexp="org/chromium/chrome/browser/TtsPlatformImpl.class" />
+ <ignore regexp="org/chromium/chrome/browser/ntp/IncognitoNewTabPage.class" />
+ <ignore regexp="org/chromium/chrome/browser/ntp/NewTabPage.class" />
+ <ignore regexp="org/chromium/chromecast/base/CastSettingsManager.class" />
+ <ignore regexp="Attribute `paddingStart` referenced here can result in a crash on some specific devices older than API 17" />
</issue>
<issue id="OldTargetApi">
- <ignore path="AndroidManifest.xml"/>
- </issue>
- <issue id="Overdraw" severity="ignore"/>
- <issue id="Recycle" severity="ignore"/>
- <issue id="Registered" severity="ignore"/>
- <issue id="RtlCompat" severity="ignore"/>
- <issue id="RtlEnabled" severity="ignore"/>
- <issue id="RtlSymmetry" severity="ignore"/>
+ <ignore path="AndroidManifest.xml" />
+ </issue>
+ <issue id="Overdraw" severity="ignore" />
+ <issue id="PackageManagerGetSignatures">
+ <ignore regexp="chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java" />
+ </issue>
+ <issue id="PluralsCandidate" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-en-rGB/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml" />
+ </issue>
+ <issue id="Recycle" severity="ignore" />
+ <issue id="Registered" severity="ignore" />
+ <issue id="RtlCompat" severity="ignore" />
+ <issue id="RtlEnabled" severity="ignore" />
+ <issue id="RtlSymmetry" severity="ignore" />
<issue id="SdCardPath">
- <ignore path="content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java"/>
- </issue>
- <issue id="SetJavaScriptEnabled" severity="ignore"/>
+ <ignore regexp="content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java" />
+ </issue>
+ <issue id="SetJavaScriptEnabled" severity="ignore" />
+ <issue id="SignatureOrSystemPermissions" severity="ignore" />
+ <issue id="StringFormatCount" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml" />
+ </issue>
+ <issue id="StringFormatInvalid" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-da/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-pl/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sv/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-tl/android_chrome_strings.xml" />
+ </issue>
+ <issue id="TypographyDashes" severity="Error">
+ <ignore regexp="chrome/app/policy/android/values-v21/restriction_values.xml" />
+ </issue>
+ <issue id="Typos" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-tr/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml" />
+ </issue>
+ <issue id="UnusedAttribute" severity="ignore" />
+ <issue id="UnusedIds" severity="ignore" />
+ <issue id="UnusedQuantity" severity="Error">
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-cs/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-in/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ja/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-ko/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-lt/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-sk/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-th/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-vi/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh-rCN/android_chrome_strings.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values-zh/android_chrome_strings.xml" />
+ </issue>
<issue id="UnusedResources">
- <!-- Used by Android's policies system -->
- <ignore regexp="restriction_values.xml" />
- <ignore path="android_webview/tools/automated_ui_tests/java/res/" />
+ <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/remoting_strings.xml" />
+ <ignore regexp="gen/blimp/client/blimp_strings_grd.resources.zip/values/android_blimp_strings.xml" />
+ <ignore regexp="gen/android_webview/locale_paks.resources.zip/values/locale-paks.xml" />
+ <ignore regexp="gen/android_webview/strings_grd.resources.zip/values/android_webview_strings.xml" />
+ <ignore regexp="gen/remoting/resources/strings_java.resources.zip/values/remoting_strings.xml" />
+ <ignore regexp="blimp/client/app/android/java/res/layout/blimp_main.xml" />
+ <ignore regexp="blimp/client/app/android/java/res/layout/toolbar_popup_item.xml" />
+ <ignore regexp="blimp/client/app/android/java/res/values/dimens.xml" />
+ <ignore regexp="blimp/client/app/android/java/res/xml/about_blimp_preferences.xml" />
+ <ignore regexp="chrome/android/webapk/shell_apk/res/layout/main.xml" />
+ <ignore regexp="remoting/android/java/res/layout/navigation_list_item.xml" />
+ <ignore regexp="gen/chrome/android/chrome_strings_grd.resources.zip/values/android_chrome_strings.xml" />
+ <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/values/components_strings.xml" />
+ <ignore regexp="android_ui_strings.xml" />
+ <ignore regexp="android_webview/tools/automated_ui_tests/java/res/" />
<!--
This file isn't used if the target SDK version is less than 24.
TODO(estevenson) remove this and the conditional inclusion in
AndroidManifest.xml after rolling to SDK 24.
-->
- <ignore path="chrome/android/java/res/xml/network_security_config.xml" />
- </issue>
- <issue id="SignatureOrSystemPermissions" severity="ignore"/>
- <issue id="UnusedAttribute" severity="ignore"/>
- <issue id="ViewConstructor" severity="ignore"/>
- <issue id="WrongCall" severity="ignore"/>
+ <ignore regexp="chrome/android/java/res/xml/network_security_config.xml" />
+ <ignore regexp="chrome/android/java/res/values/ids.xml" />
+ <!-- Used by Android's policies system -->
+ <ignore regexp="restriction_values.xml" />
+ <ignore regexp="gen/components/strings/components_strings_grd.resources.zip/values.*/components_strings.xml" />
+ <ignore regexp="clank.*" />
+ <ignore regexp="chromecast/browser/android/apk/res/values/strings.xml" />
+ </issue>
<issue id="UselessParent">
- <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml" />
+ <ignore regexp="android_webview/tools/system_webview_shell/apk/res/layout/activity_webview_browser.xml" />
+ <ignore regexp="tools/android/kerberos/SpnegoAuthenticator/res/layout/activity_account_authenticator.xml" />
+ <ignore regexp="chrome/android/java/res/layout/data_reduction_promo_screen.xml" />
+ </issue>
+ <issue id="UsesMinSdkAttributes" severity="Error">
+ <ignore regexp="AndroidManifest.xml" />
+ </issue>
+ <issue id="ValidFragment" severity="Error">
+ <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java" />
+ <ignore regexp="blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/MockPreferences.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/BaseMediaRouteDialogManager.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteChooserDialogManager.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteControllerDialogManager.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java" />
+ <ignore regexp="media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java" />
+ </issue>
+ <issue id="ViewConstructor" severity="ignore" />
+ <issue id="WrongCall" severity="ignore" />
+ <issue id="WrongConstant">
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java" />
+ <ignore regexp="chrome/android/java/src/org/chromium/chrome/browser/signin/SigninAndSyncView.java" />
+ <ignore regexp="content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java" />
</issue>
</lint>
« no previous file with comments | « build/android/gyp/lint.py ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698