Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2241873002: Remove stencil settings param from stencilPath() (Closed)

Created:
4 years, 4 months ago by csmartdalton
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove stencil settings param from stencilPath() stencilPath() picks its own user stencil settings. This argument should not be there. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241873002 Committed: https://skia.googlesource.com/skia/+/5c6fc4fbfd425a91bbb9cd493517bd3c9aa6ad55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
M src/gpu/GrDrawContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrDrawContextPriv.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 3 chunks +18 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 4 months ago (2016-08-12 20:03:22 UTC) #3
bsalomon
lgtm
4 years, 4 months ago (2016-08-12 21:35:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241873002/1
4 years, 4 months ago (2016-08-12 21:44:25 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 22:11:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5c6fc4fbfd425a91bbb9cd493517bd3c9aa6ad55

Powered by Google App Engine
This is Rietveld 408576698