Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 224173007: Remove setOpenedByDOM calls in CreateWindow.cpp. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 8 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@expose-opend-by-dom
Visibility:
Public.

Description

Remove setOpenedByDOM calls in CreateWindow.cpp. They are now redundant with calls in Chromium code, as of https://codereview.chromium.org/212703005 BUG=357579 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171881

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/page/CreateWindow.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
This bit should now be managed entirely by Chromium.
6 years, 8 months ago (2014-04-17 15:33:22 UTC) #1
Nate Chapin
k. LGTM
6 years, 8 months ago (2014-04-17 16:52:09 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-17 18:42:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/224173007/20001
6 years, 8 months ago (2014-04-17 18:43:05 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 19:22:33 UTC) #5
Message was sent while issue was closed. 
Change committed as 171881

Powered by Google App Engine
This is Rietveld 408576698