Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 224173007: Remove setOpenedByDOM calls in CreateWindow.cpp. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@expose-opend-by-dom
Patch Set: Rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index 4eb99754adb375fdef70fe78b72dae905084ecaa..7068fd93bf124fd535ca0edcc45ab7f58387e5ff 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -143,7 +143,6 @@ LocalFrame* createWindow(const String& urlString, const AtomicString& frameName,
newFrame->loader().forceSandboxFlags(openerFrame.document()->sandboxFlags());
newFrame->loader().setOpener(&openerFrame);
- newFrame->page()->setOpenedByDOM();
if (newFrame->domWindow()->isInsecureScriptAccess(callingWindow, completedURL))
return newFrame;
@@ -179,7 +178,6 @@ void createWindowForRequest(const FrameLoadRequest& request, LocalFrame& openerF
LocalFrame* newFrame = createWindow(openerFrame, openerFrame, request, features, policy, shouldSendReferrer, created);
if (!newFrame)
return;
- newFrame->page()->setOpenedByDOM();
if (shouldSendReferrer == MaybeSendReferrer) {
newFrame->loader().setOpener(&openerFrame);
newFrame->document()->setReferrerPolicy(openerFrame.document()->referrerPolicy());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698