Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2413)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

Issue 2241673002: Make UnsafeResource hold a WebContents getter instead of RenderFrame ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
index 54f7a85d8d5ca713886cc7c3c0685f5e207551e1..d61f3cb3bc4e1d5afb37f65e749ac96b84b78e1c 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc
@@ -262,15 +262,13 @@ void SafeBrowsingResourceThrottle::OnCheckBrowseUrlResult(
&SafeBrowsingResourceThrottle::OnBlockingPageComplete, AsWeakPtr());
resource.callback_thread = content::BrowserThread::GetTaskRunnerForThread(
content::BrowserThread::IO);
- resource.render_process_host_id = info->GetChildID();
- resource.render_frame_id = info->GetRenderFrameID();
+ resource.web_contents_getter = info->GetWebContentsGetterForRequest();
resource.threat_source = database_manager_->GetThreatSource();
state_ = STATE_DISPLAYING_BLOCKING_PAGE;
content::BrowserThread::PostTask(
- content::BrowserThread::UI,
- FROM_HERE,
+ content::BrowserThread::UI, FROM_HERE,
base::Bind(&SafeBrowsingResourceThrottle::StartDisplayingBlockingPage,
AsWeakPtr(), ui_manager_, resource));
}
@@ -279,11 +277,8 @@ void SafeBrowsingResourceThrottle::StartDisplayingBlockingPage(
const base::WeakPtr<SafeBrowsingResourceThrottle>& throttle,
scoped_refptr<SafeBrowsingUIManager> ui_manager,
const SafeBrowsingUIManager::UnsafeResource& resource) {
- content::RenderFrameHost* rfh = content::RenderFrameHost::FromID(
- resource.render_process_host_id, resource.render_frame_id);
- if (rfh) {
- content::WebContents* web_contents =
- content::WebContents::FromRenderFrameHost(rfh);
+ content::WebContents* web_contents = resource.web_contents_getter.Run();
+ if (web_contents) {
prerender::PrerenderContents* prerender_contents =
prerender::PrerenderContents::FromWebContents(web_contents);

Powered by Google App Engine
This is Rietveld 408576698