Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

Issue 2241673002: Make UnsafeResource hold a WebContents getter instead of RenderFrame ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/safe_browsing_resource_throttle.h" 5 #include "chrome/browser/renderer_host/safe_browsing_resource_throttle.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 resource.original_url = request_->original_url(); 255 resource.original_url = request_->original_url();
256 resource.redirect_urls = redirect_urls_; 256 resource.redirect_urls = redirect_urls_;
257 resource.is_subresource = resource_type_ != content::RESOURCE_TYPE_MAIN_FRAME; 257 resource.is_subresource = resource_type_ != content::RESOURCE_TYPE_MAIN_FRAME;
258 resource.is_subframe = resource_type_ == content::RESOURCE_TYPE_SUB_FRAME; 258 resource.is_subframe = resource_type_ == content::RESOURCE_TYPE_SUB_FRAME;
259 resource.threat_type = threat_type; 259 resource.threat_type = threat_type;
260 resource.threat_metadata = metadata; 260 resource.threat_metadata = metadata;
261 resource.callback = base::Bind( 261 resource.callback = base::Bind(
262 &SafeBrowsingResourceThrottle::OnBlockingPageComplete, AsWeakPtr()); 262 &SafeBrowsingResourceThrottle::OnBlockingPageComplete, AsWeakPtr());
263 resource.callback_thread = content::BrowserThread::GetTaskRunnerForThread( 263 resource.callback_thread = content::BrowserThread::GetTaskRunnerForThread(
264 content::BrowserThread::IO); 264 content::BrowserThread::IO);
265 resource.render_process_host_id = info->GetChildID(); 265 resource.web_contents_getter = info->GetWebContentsGetterForRequest();
266 resource.render_frame_id = info->GetRenderFrameID();
267 resource.threat_source = database_manager_->GetThreatSource(); 266 resource.threat_source = database_manager_->GetThreatSource();
268 267
269 state_ = STATE_DISPLAYING_BLOCKING_PAGE; 268 state_ = STATE_DISPLAYING_BLOCKING_PAGE;
270 269
271 content::BrowserThread::PostTask( 270 content::BrowserThread::PostTask(
272 content::BrowserThread::UI, 271 content::BrowserThread::UI, FROM_HERE,
273 FROM_HERE,
274 base::Bind(&SafeBrowsingResourceThrottle::StartDisplayingBlockingPage, 272 base::Bind(&SafeBrowsingResourceThrottle::StartDisplayingBlockingPage,
275 AsWeakPtr(), ui_manager_, resource)); 273 AsWeakPtr(), ui_manager_, resource));
276 } 274 }
277 275
278 void SafeBrowsingResourceThrottle::StartDisplayingBlockingPage( 276 void SafeBrowsingResourceThrottle::StartDisplayingBlockingPage(
279 const base::WeakPtr<SafeBrowsingResourceThrottle>& throttle, 277 const base::WeakPtr<SafeBrowsingResourceThrottle>& throttle,
280 scoped_refptr<SafeBrowsingUIManager> ui_manager, 278 scoped_refptr<SafeBrowsingUIManager> ui_manager,
281 const SafeBrowsingUIManager::UnsafeResource& resource) { 279 const SafeBrowsingUIManager::UnsafeResource& resource) {
282 content::RenderFrameHost* rfh = content::RenderFrameHost::FromID( 280 content::WebContents* web_contents = resource.web_contents_getter.Run();
283 resource.render_process_host_id, resource.render_frame_id); 281 if (web_contents) {
284 if (rfh) {
285 content::WebContents* web_contents =
286 content::WebContents::FromRenderFrameHost(rfh);
287 prerender::PrerenderContents* prerender_contents = 282 prerender::PrerenderContents* prerender_contents =
288 prerender::PrerenderContents::FromWebContents(web_contents); 283 prerender::PrerenderContents::FromWebContents(web_contents);
289 284
290 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory = 285 subresource_filter::ContentSubresourceFilterDriverFactory* driver_factory =
291 subresource_filter::ContentSubresourceFilterDriverFactory:: 286 subresource_filter::ContentSubresourceFilterDriverFactory::
292 FromWebContents(web_contents); 287 FromWebContents(web_contents);
293 DCHECK(driver_factory); 288 DCHECK(driver_factory);
294 driver_factory->OnMainResourceMatchedSafeBrowsingBlacklist( 289 driver_factory->OnMainResourceMatchedSafeBrowsingBlacklist(
295 resource.url, resource.redirect_urls, 290 resource.url, resource.redirect_urls,
296 resource.threat_metadata.threat_pattern_type); 291 resource.threat_metadata.threat_pattern_type);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 unchecked_redirect_url_, "defer_reason", 388 unchecked_redirect_url_, "defer_reason",
394 "resumed_redirect"); 389 "resumed_redirect");
395 } 390 }
396 } 391 }
397 392
398 if (resume) { 393 if (resume) {
399 defer_state_ = DEFERRED_NONE; 394 defer_state_ = DEFERRED_NONE;
400 controller()->Resume(); 395 controller()->Resume();
401 } 396 }
402 } 397 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698