Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3342)

Unified Diff: blimp/client/core/contents/blimp_contents_manager_unittest.cc

Issue 2241623002: blimp: Move compositing, input and render widget feature to client/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments from #7 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/blimp_contents_manager_unittest.cc
diff --git a/blimp/client/core/contents/blimp_contents_manager_unittest.cc b/blimp/client/core/contents/blimp_contents_manager_unittest.cc
index 422b77157ef9c49bbfd94dfc69fb02b1109ef2d3..eb102f5ac0a569c4c2b2d83ba333f16665d66a6c 100644
--- a/blimp/client/core/contents/blimp_contents_manager_unittest.cc
+++ b/blimp/client/core/contents/blimp_contents_manager_unittest.cc
@@ -19,7 +19,9 @@ namespace {
TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {
base::MessageLoop loop;
- BlimpContentsManager blimp_contents_manager;
+ RenderWidgetFeature feature;
+ CompositorDepsProvider::Initialize(true);
+ BlimpContentsManager blimp_contents_manager(&feature);
std::unique_ptr<BlimpContentsImpl> blimp_contents =
blimp_contents_manager.CreateBlimpContents();
@@ -27,19 +29,26 @@ TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {
BlimpContentsImpl* existing_contents =
blimp_contents_manager.GetBlimpContents(id);
EXPECT_EQ(blimp_contents.get(), existing_contents);
+ blimp_contents.reset();
+ CompositorDepsProvider::Terminate();
}
TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) {
- BlimpContentsManager blimp_contents_manager;
+ RenderWidgetFeature feature;
+ CompositorDepsProvider::Initialize(true);
+ BlimpContentsManager blimp_contents_manager(&feature);
BlimpContentsImpl* existing_contents =
blimp_contents_manager.GetBlimpContents(kDummyTabId);
EXPECT_EQ(nullptr, existing_contents);
+ CompositorDepsProvider::Terminate();
}
TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) {
base::MessageLoop loop;
- BlimpContentsManager blimp_contents_manager;
+ RenderWidgetFeature feature;
+ CompositorDepsProvider::Initialize(true);
+ BlimpContentsManager blimp_contents_manager(&feature);
int id;
std::unique_ptr<BlimpContentsImpl> blimp_contents =
@@ -52,6 +61,7 @@ TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) {
loop.RunUntilIdle();
EXPECT_EQ(nullptr, blimp_contents_manager.GetBlimpContents(id));
+ CompositorDepsProvider::Terminate();
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698