Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: blimp/client/core/contents/blimp_contents_manager_unittest.cc

Issue 2241623002: blimp: Move compositing, input and render widget feature to client/core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments from #7 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/blimp_contents_manager.h" 5 #include "blimp/client/core/contents/blimp_contents_manager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "blimp/client/core/contents/blimp_contents_impl.h" 9 #include "blimp/client/core/contents/blimp_contents_impl.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace { 12 namespace {
13 const int kDummyTabId = 0; 13 const int kDummyTabId = 0;
14 } 14 }
15 15
16 namespace blimp { 16 namespace blimp {
17 namespace client { 17 namespace client {
18 namespace { 18 namespace {
19 19
20 TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) { 20 TEST(BlimpContentsManagerUnittest, GetExistingBlimpContents) {
21 base::MessageLoop loop; 21 base::MessageLoop loop;
22 BlimpContentsManager blimp_contents_manager; 22 RenderWidgetFeature feature;
23 CompositorDepsProvider::Initialize(true);
24 BlimpContentsManager blimp_contents_manager(&feature);
23 25
24 std::unique_ptr<BlimpContentsImpl> blimp_contents = 26 std::unique_ptr<BlimpContentsImpl> blimp_contents =
25 blimp_contents_manager.CreateBlimpContents(); 27 blimp_contents_manager.CreateBlimpContents();
26 int id = blimp_contents->id(); 28 int id = blimp_contents->id();
27 BlimpContentsImpl* existing_contents = 29 BlimpContentsImpl* existing_contents =
28 blimp_contents_manager.GetBlimpContents(id); 30 blimp_contents_manager.GetBlimpContents(id);
29 EXPECT_EQ(blimp_contents.get(), existing_contents); 31 EXPECT_EQ(blimp_contents.get(), existing_contents);
32 blimp_contents.reset();
33 CompositorDepsProvider::Terminate();
30 } 34 }
31 35
32 TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) { 36 TEST(BlimpContentsManagerUnittest, GetNonExistingBlimpContents) {
33 BlimpContentsManager blimp_contents_manager; 37 RenderWidgetFeature feature;
38 CompositorDepsProvider::Initialize(true);
39 BlimpContentsManager blimp_contents_manager(&feature);
34 40
35 BlimpContentsImpl* existing_contents = 41 BlimpContentsImpl* existing_contents =
36 blimp_contents_manager.GetBlimpContents(kDummyTabId); 42 blimp_contents_manager.GetBlimpContents(kDummyTabId);
37 EXPECT_EQ(nullptr, existing_contents); 43 EXPECT_EQ(nullptr, existing_contents);
44 CompositorDepsProvider::Terminate();
38 } 45 }
39 46
40 TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) { 47 TEST(BlimpContentsManagerUnittest, GetDestroyedBlimpContents) {
41 base::MessageLoop loop; 48 base::MessageLoop loop;
42 BlimpContentsManager blimp_contents_manager; 49 RenderWidgetFeature feature;
50 CompositorDepsProvider::Initialize(true);
51 BlimpContentsManager blimp_contents_manager(&feature);
43 int id; 52 int id;
44 53
45 std::unique_ptr<BlimpContentsImpl> blimp_contents = 54 std::unique_ptr<BlimpContentsImpl> blimp_contents =
46 blimp_contents_manager.CreateBlimpContents(); 55 blimp_contents_manager.CreateBlimpContents();
47 id = blimp_contents.get()->id(); 56 id = blimp_contents.get()->id();
48 BlimpContentsImpl* existing_contents = 57 BlimpContentsImpl* existing_contents =
49 blimp_contents_manager.GetBlimpContents(id); 58 blimp_contents_manager.GetBlimpContents(id);
50 EXPECT_EQ(blimp_contents.get(), existing_contents); 59 EXPECT_EQ(blimp_contents.get(), existing_contents);
51 blimp_contents.reset(); 60 blimp_contents.reset();
52 61
53 loop.RunUntilIdle(); 62 loop.RunUntilIdle();
54 EXPECT_EQ(nullptr, blimp_contents_manager.GetBlimpContents(id)); 63 EXPECT_EQ(nullptr, blimp_contents_manager.GetBlimpContents(id));
64 CompositorDepsProvider::Terminate();
55 } 65 }
56 66
57 } // namespace 67 } // namespace
58 } // namespace client 68 } // namespace client
59 } // namespace blimp 69 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698