Issue 22416003: Make JSON::Parse return Local<Value>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22416003: Make JSON::Parse return Local<Value> (Closed)

Created:
7 years, 4 months ago by tyoshino (SeeGerritForStatus)

Modified:
7 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit), Yang

CC:
v8-dev, jochen (gone - plz use gerrit)

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Make JSON::Parse return Local<Value> It should be able to return Smi, etc. Not only JSObject. BUG=v8:2821 TEST=cctest/test-api/JSONParseNumber R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16092

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -7 lines)			Patch
M	include/v8.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+12 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

jochen (gone - plz use gerrit)

ah yes, I keep forgetting that v8::Value = v8::internal::Object and v8::Object == v8::internal::JSObject

7 years, 4 months ago (2013-08-07 02:28:09 UTC) #2

Yang

On 2013/08/07 02:28:09, jochen wrote: > ah yes, I keep forgetting that v8::Value = v8::internal::Object ...

7 years, 4 months ago (2013-08-07 07:39:02 UTC) #3

Yang

7 years, 4 months ago (2013-08-07 09:11:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16092 (presubmit successful).