[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile

[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8
Cr-Commit-Position: refs/heads/master@{#414052}

[yunchao, 2016-08-12 08:01:16]

Description was changed from

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in core profile

BUG=
==========

to

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in core profile

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-08-12 08:01:38]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 08:01:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 08:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:50:09]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-17 02:57:03]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 02:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-08-17 03:19:15]

Description was changed from

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in core profile

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core
profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-08-17 03:19:15]

yunchao.he@intel.com changed reviewers:
+ kbr@chromium.org, piman@chromium.org, qiankun.miao@intel.com, zmo@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 03:38:16]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-17 07:50:40]

The last patch about GLES2CmdDecoder::CopyTexSubImage3D. PTAL. Thanks a lot!

BTW, do you have any suggestions about writing a test in WebGL 2 CTS? I looked
into the tests for luminance/alpha formats for CopyTexSubImage2D. That test is
in deqp. It is based on ReferenceRenderer, which is a CPU-based renderer who
implemented OGL/GLES APIs. But there is no tests for luminance/alpha for
CopyTexSubImage3D in deqp. 

If we want to add a test case in WebGL CTS to cover this feature, It is better
to add it into conformance2. So there is no a CPU-based ReferenceRenderer to
use.

[piman, 2016-08-17 16:47:27]

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13302: x, y, width, height,
Should this be destX/destY/copyX/copyY/copyWidth/copyHeight?

[Ken Russell (switch to Gerrit), 2016-08-17 23:27:00]

Please do add a test for this under conformance2/ . Thanks.

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:50: void
DoCopyTexSubImageToLUMAComatabilityTexture(
zmo@ just fixed a couple of typos here.

[yunchao, 2016-08-18 08:21:15]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 08:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:33:16]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yunchao, 2016-08-18 08:59:48]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 09:00:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-08-18 09:27:48]

Patchset #5 (id:80001) has been deleted

[yunchao, 2016-08-18 09:28:04]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-08-18 10:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 10:26:38]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-22 14:57:20]

Thanks for your review. code has been updated accordingly, could you have
another look? 

The conformance test is here:
https://github.com/JiangYizhou/WebGL/commit/78f5e5f8bdefb65009af0cb2e8cc681d9....

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:50: void
DoCopyTexSubImageToLUMAComatabilityTexture(
On 2016/08/17 23:27:00, Ken Russell wrote:
> zmo@ just fixed a couple of typos here.

Done.

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2241593003/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13302: x, y, width, height,
On 2016/08/17 16:47:27, piman wrote:
> Should this be destX/destY/copyX/copyY/copyWidth/copyHeight?

Done.

[Zhenyao Mo, 2016-08-22 17:57:15]

https://codereview.chromium.org/2241593003/diff/100001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2241593003/diff/100001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13319: internal_format, type,
level, xoffset, yoffset, zoffset,
Same question, should xoffset/yoffset be destX/destY?

[yunchao, 2016-08-22 23:02:18]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:03:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 01:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 01:05:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yunchao, 2016-08-23 13:03:20]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 13:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 13:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 13:29:00]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-23 13:32:17]

Thanks for your review, Zhenyao. Code has been updated, PTAL. Thanks!

https://codereview.chromium.org/2241593003/diff/100001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2241593003/diff/100001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13319: internal_format, type,
level, xoffset, yoffset, zoffset,
On 2016/08/22 17:57:15, Zhenyao Mo wrote:
> Same question, should xoffset/yoffset be destX/destY?

You are right.

[Zhenyao Mo, 2016-08-23 15:49:35]

lgtm

[piman, 2016-08-23 18:33:02]

lgtm

[yunchao, 2016-08-24 08:09:49]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-08-24 08:10:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 09:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 09:41:18]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[yunchao, 2016-08-24 09:45:37]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 09:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 10:29:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 10:29:53]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-08-24 12:04:19]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-08-24 12:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 12:09:20]

Description was changed from

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core
profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core
profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-08-24 12:09:21]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-08-24 12:12:04]

Description was changed from

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core
profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core
profile

BUG=631934, 638470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8
Cr-Commit-Position: refs/heads/master@{#414052}
==========

[commit-bot: I haz the power, 2016-08-24 12:12:05]

Patchset 5 (id:??) landed as
https://crrev.com/0876d0ee62855de3a9329f9a758725130b1a2ae8
Cr-Commit-Position: refs/heads/master@{#414052}