[Command buffer] CopyTexSubImage3D: emulate unsized format in desktop core profile

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 13026 matching lines @@
     memset(zero.get(), 0, pixels_size);
     glTexImage2D(target, level, TextureManager::AdjustTexInternalFormat(
                                     feature_info_.get(), internal_format),
                  width, height, border, format, type, zero.get());
     if (copyHeight > 0 && copyWidth > 0) {
       GLint dx = copyX - x;
       GLint dy = copyY - y;
       GLint destX = dx;
       GLint destY = dy;
       if (requires_luma_blit) {
-        copy_tex_image_blit_->DoCopyTexSubImage2DToLUMACompatibilityTexture(
+        copy_tex_image_blit_->DoCopyTexSubImageToLUMACompatibilityTexture(
             this, texture->service_id(), texture->target(), target, format,
-            type, level, destX, destY, copyX, copyY, copyWidth, copyHeight,
+            type, level, destX, destY, 0, copyX, copyY, copyWidth, copyHeight,
             GetBoundReadFrameBufferServiceId(),
             GetBoundReadFrameBufferInternalFormat());
       } else {
         glCopyTexSubImage2D(target, level, destX, destY, copyX, copyY,
                             copyWidth, copyHeight);
       }
     }
   } else {
     GLenum final_internal_format = TextureManager::AdjustTexInternalFormat(
         feature_info_.get(), internal_format);
@@ skipping 151 matching lines @@
     // Write all pixels in below.
     texture_manager()->SetLevelCleared(texture_ref, target, level, true);
   }
 
   if (copyHeight > 0 && copyWidth > 0) {
     if (CopyTexImageResourceManager::CopyTexImageRequiresBlit(
             feature_info_.get(), internal_format)) {
       if (!InitializeCopyTexImageBlitter("glCopyTexSubImage2D")) {
         return;
       }
-      copy_tex_image_blit_->DoCopyTexSubImage2DToLUMACompatibilityTexture(
+      copy_tex_image_blit_->DoCopyTexSubImageToLUMACompatibilityTexture(
           this, texture->service_id(), texture->target(), target,
-          internal_format, type, level, xoffset, yoffset, x, y, width, height,
+          internal_format, type, level, xoffset, yoffset, 0,
+          copyX, copyY, copyWidth, copyHeight,
           GetBoundReadFrameBufferServiceId(),
           GetBoundReadFrameBufferInternalFormat());
     } else {
       glCopyTexSubImage2D(target, level, destX, destY, copyX, copyY, copyWidth,
                           copyHeight);
     }
   }
 
   // This may be a slow command.  Exit command processing to allow for
   // context preemption and GPU watchdog checks.
@@ skipping 66 matching lines @@
   // for TexSubImage3D.
   if (!texture->IsLevelCleared(target, level)) {
     if (!texture_manager()->ClearTextureLevel(this, texture_ref, target,
                                               level)) {
       LOCAL_SET_GL_ERROR(GL_OUT_OF_MEMORY, func_name, "dimensions too big");
       return;
     }
     DCHECK(texture->IsLevelCleared(target, level));
   }
 
-  // TODO(yunchao): Follow-up CLs are necessary. For instance:
-  // 1. emulation of unsized formats in core profile
-
   if (copyHeight > 0 && copyWidth > 0) {
-    glCopyTexSubImage3D(target, level, destX, destY, zoffset,
-                        copyX, copyY, copyWidth, copyHeight);
+    if (CopyTexImageResourceManager::CopyTexImageRequiresBlit(
+            feature_info_.get(), internal_format)) {
+      if (!InitializeCopyTexImageBlitter(func_name)) {
+        return;
+      }
+      copy_tex_image_blit_->DoCopyTexSubImageToLUMACompatibilityTexture(
+          this, texture->service_id(), texture->target(), target,
+          internal_format, type, level, xoffset, yoffset, zoffset,

[Zhenyao Mo, 2016/08/22 17:57:15]

Same question, should xoffset/yoffset be destX/destY?

[yunchao, 2016/08/23 13:32:17]

You are right.

+          copyX, copyY, copyWidth, copyHeight,
+          GetBoundReadFrameBufferServiceId(),
+          GetBoundReadFrameBufferInternalFormat());
+    } else {
+      glCopyTexSubImage3D(target, level, destX, destY, zoffset,
+                          copyX, copyY, copyWidth, copyHeight);
+    }
   }
 
   // This may be a slow command.  Exit command processing to allow for
   // context preemption and GPU watchdog checks.
   ExitCommandProcessingEarly();
 }
 
 error::Error GLES2DecoderImpl::HandleTexSubImage2D(uint32_t immediate_data_size,
                                                    const void* cmd_data) {
   const gles2::cmds::TexSubImage2D& c =
@@ skipping 4454 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu