Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2241513002: gn: Stop asserting on |use_gconf| when looking for atk. (Closed)

Created:
4 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Stop asserting on |use_gconf| when looking for atk. |use_gconf| was added back in commit 2f4a32e98 ("linux gn config should check use_gconf before looking for it with pkg-config") back when the pkg-config calls to atk and gconf were grouped together within a single if check. Since then, commit 95ba4446 ("Move linux pkg_config() calls into separate BUILD.gn files") has split all the pkg-config checks. As atk itself does not depend on gconf, we can drop use_gconf from the assertion in atk's BUILD.gn. R=brettw@chromium.org,dpranke@chromium.org,mostynb@opera.com BUG=632297 Committed: https://crrev.com/9ca5a503b8f28258126226df203bef7fd316dfad Cr-Commit-Position: refs/heads/master@{#411440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/linux/atk/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Raphael Kubo da Costa (rakuco)
4 years, 4 months ago (2016-08-11 17:16:36 UTC) #1
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-11 17:18:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241513002/1
4 years, 4 months ago (2016-08-11 17:25:00 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/110929)
4 years, 4 months ago (2016-08-11 17:44:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2241513002/1
4 years, 4 months ago (2016-08-11 20:02:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 23:35:25 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 23:38:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ca5a503b8f28258126226df203bef7fd316dfad
Cr-Commit-Position: refs/heads/master@{#411440}

Powered by Google App Engine
This is Rietveld 408576698