Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: build/config/linux/atk/BUILD.gn

Issue 2241513002: gn: Stop asserting on |use_gconf| when looking for atk. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/linux/pkg_config.gni") 6 import("//build/config/linux/pkg_config.gni")
7 7
8 # CrOS doesn't install GTK, gconf or any gnome packages. 8 # CrOS doesn't install GTK, gconf or any gnome packages.
9 assert(!is_chromeos && use_gconf) 9 assert(!is_chromeos)
10 10
11 # These packages should _only_ be expected when building for a target. 11 # These packages should _only_ be expected when building for a target.
12 # If these extra checks are not run, gconf is required when building host 12 # If these extra checks are not run, gconf is required when building host
13 # tools for a CrOS build. 13 # tools for a CrOS build.
14 assert(current_toolchain == default_toolchain) 14 assert(current_toolchain == default_toolchain)
15 15
16 pkg_config("atk") { 16 pkg_config("atk") {
17 packages = [ "atk" ] 17 packages = [ "atk" ]
18 atk_lib_dir = exec_script(pkg_config_script, 18 atk_lib_dir = exec_script(pkg_config_script,
19 pkg_config_args + [ 19 pkg_config_args + [
(...skipping 11 matching lines...) Expand all
31 cflags = [ 31 cflags = [
32 # glib uses the pre-c++11 typedef-as-static_assert hack. 32 # glib uses the pre-c++11 typedef-as-static_assert hack.
33 "-Wno-unused-local-typedef", 33 "-Wno-unused-local-typedef",
34 34
35 # G_DEFINE_TYPE automatically generates a *get_instance_private 35 # G_DEFINE_TYPE automatically generates a *get_instance_private
36 # inline function after glib 2.37. That's unused. Prevent to 36 # inline function after glib 2.37. That's unused. Prevent to
37 # complain about it. 37 # complain about it.
38 "-Wno-unused-function", 38 "-Wno-unused-function",
39 ] 39 ]
40 } 40 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698